From: Jeff Garzik <jeff@garzik.org>
To: Mark Lord <lkml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alan <alan@lxorguk.ukuu.org.uk>
Subject: Re: libata git tree, mbox queue status and contents
Date: Wed, 08 Aug 2007 12:28:58 -0400 [thread overview]
Message-ID: <46B9EF4A.1030609@garzik.org> (raw)
In-Reply-To: <46B9D64E.6070609@rtr.ca>
Mark Lord wrote:
> Jeff,
>
> This patch (below) is needed by WD drives that powerup-in-standby.
> drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after
> drivers/ata/libata-core.c
> --- a/drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after
> +++ a/drivers/ata/libata-core.c
> @@ -1723,7 +1723,7 @@ int ata_dev_read_id(struct ata_device *d
> tf.protocol = ATA_PROT_NODATA;
> tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
> err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0);
> - if (err_mask) {
> + if (err_mask && id[2] != 0x738c) {
> rc = -EIO;
> reason = "SPINUP failed";
> goto err_out;
Thanks for the poke, it wasn't in my queue.
Jeff
next prev parent reply other threads:[~2007-08-08 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 16:09 libata git tree, mbox queue status and contents Jeff Garzik
2007-08-03 16:20 ` Alan Cox
2007-08-04 8:14 ` Tejun Heo
2007-08-05 14:34 ` Sergei Shtylyov
2007-08-08 14:42 ` Mark Lord
2007-08-08 16:28 ` Jeff Garzik [this message]
2007-08-13 12:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B9EF4A.1030609@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).