From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: bzolnier@gmail.com, rah@bash.sh, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374
Date: Fri, 10 Aug 2007 19:41:59 +0400 [thread overview]
Message-ID: <46BC8747.4020307@ru.mvista.com> (raw)
In-Reply-To: <20070806202958.25670cc1@the-village.bc.nu>
Alan Cox wrote:
>>+ if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) {
>>+ struct pci_dev *dev1 = pci_get_slot(dev->bus,
>>+ dev->devfn - 1);
> Can be NULL
Not really. This may not be called if it's NULL -- see hpt374_init_setup().
Maybe worth a comment though...
>>+ unsigned long io_base = pci_resource_start(dev1, 4);
> Kaboom
That was a dud bomb. ;-)
MBR, Sergei
next prev parent reply other threads:[~2007-08-10 15:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 20:06 [PATCH 1/2] hpt366: fix PCI clock detection for HPT374 Sergei Shtylyov
2007-08-06 17:10 ` Bob Ham
2007-08-06 17:18 ` Sergei Shtylyov
2007-08-07 9:01 ` Bob Ham
2007-08-06 19:29 ` Alan Cox
2007-08-10 15:41 ` Sergei Shtylyov [this message]
2007-08-10 17:19 ` Alan Cox
2007-08-10 17:29 ` Sergei Shtylyov
2007-08-10 21:54 ` Bartlomiej Zolnierkiewicz
2007-08-11 16:03 ` Sergei Shtylyov
2007-08-11 16:41 ` Bartlomiej Zolnierkiewicz
2007-08-11 16:54 ` Sergei Shtylyov
2007-08-11 17:07 ` Bartlomiej Zolnierkiewicz
2007-08-11 17:23 ` Sergei Shtylyov
2007-08-11 21:31 ` Bartlomiej Zolnierkiewicz
2007-08-17 17:43 ` Sergei Shtylyov
2007-08-08 21:10 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BC8747.4020307@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=rah@bash.sh \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).