Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:

>>  101 files changed, 1880 insertions(+), 2828 deletions(-)

>> please look at -mm or IDE quilt tree instead. :)

>    Looking...

    When are you planning to push out to Linus the 
ide-mode-limiting-fixes-for-user-requested-speed-changes.patch? I'd like my 
HPT37x SATA mode filtering stuff to be atop of this one, after looking at it.

>> ide_rate_filter() happily uses ide_find_dma_mode() nowadays (however this
>> hpt366 patch is for vanilla kernel which doesn't have the needed 
>> changes).

    Yeah, it keeps being in the same vein (same bug rather :-) as the old 
code, i.e. not looking at hwif->mwdma_mask when falling back in 
ide_rate_filter()...

[...]

>> I wouldn't be surprised if we actually _decrease_ the driver size a bit
>> (in addition to removal of ~35 LOC).

>    Decrasing .init.text section's width doesn't buy you much.

    Ugh, I meant "decreasing", not decraZing (another freudian slip :-) and 
"length", not "width"

>> Thanks,
>> Bart

MBR, Sergei