From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev#upstream 1/3] libata: use ata_port_printk() in ata_wait_idle()
Date: Wed, 15 Aug 2007 04:49:20 -0400 [thread overview]
Message-ID: <46C2BE10.7040401@garzik.org> (raw)
In-Reply-To: <20070730052303.GH22374@htj.dyndns.org>
Tejun Heo wrote:
> ata_wait_idle() identified controller by printing out the address of
> the Status register. This is bogus because 1. it's iomapped address
> 2. some controllers don't have Status register and don't initialize
> the field. Use ata_port_printk() instead.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Currently there's no equivalent ata_msg_* level for ATA_DEBUG, so the
> printk is conditionalized with #ifdef ATA_DEBUG. We need to kill
> ATA_DEBUG, ATA_VERBOSE_DEBUG and integrate them into ata_msg_* in the
> future.
>
> include/linux/libata.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
applied 1-2 of 3
prev parent reply other threads:[~2007-08-15 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 5:23 [PATCH libata-dev#upstream 1/3] libata: use ata_port_printk() in ata_wait_idle() Tejun Heo
2007-07-30 5:24 ` [PATCH libata-dev#upstream 2/3] libata: add printf format attribute to ehi desc functions Tejun Heo
2007-07-30 5:25 ` [PATCH libata-dev#upstream 3/3] libata: implement and use ata_port_desc() to report port configuration Tejun Heo
2007-07-30 12:55 ` Alan Cox
2007-08-15 8:48 ` Jeff Garzik
2007-08-18 4:14 ` [PATCH libata-dev#upstream 3/3 REGENERATED] " Tejun Heo
2007-08-31 9:35 ` Jeff Garzik
2007-08-15 8:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C2BE10.7040401@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).