From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report() Date: Wed, 15 Aug 2007 04:52:42 -0400 Message-ID: <46C2BEDA.5070105@garzik.org> References: <20070731074203.GA13674@htj.dyndns.org> <20070731075100.GB13674@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:54353 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbXHOIwo (ORCPT ); Wed, 15 Aug 2007 04:52:44 -0400 In-Reply-To: <20070731075100.GB13674@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: linux-ide@vger.kernel.org, mikpe@it.uu.se Tejun Heo wrote: > EH is sometimes repeated without any error or action. For example, > this happens when probing IDENTIFY fails because of a phantom device. > In these cases, all the repeated EH does is making sure there is no > unhandled error or pending action and return. This repeation is > necessary to avoid losing any event which occurred while EH was in > progress. > > Unfortunately, this dry run causes annonying "EH pending after > completion" message. This patch moves the repeat reporting into > ata_eh_report() such that it's more compact and skipped on dry runs. > > Signed-off-by: Tejun Heo > Cc: Mikael Pettersson > --- > Mikael, please verify this removes the annonying message you're > seeing. > > Thanks. > > drivers/ata/libata-eh.c | 26 ++++++++++++++++---------- > include/linux/libata.h | 5 +++-- > 2 files changed, 19 insertions(+), 12 deletions(-) this will want a rediff too, but looks OK to me