[PATCH 1/4] libata: ACPI checks for 80wire cable

[PATCH 1/4] libata: ACPI checks for 80wire cable

[Alan Cox]

We can use the ACPI mode information with several drivers as a hint to
cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then
we know the BIOS thinks there are 80wire cables. If it doesn't set such a
mode or it has no ACPI method then we get no further information and can
rely on existing approaches

Introduce the function headers needed. Null it out for non ACPI boxes

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/include/linux/libata.h linux-2.6.23rc1-mm1/include/linux/libata.h
--- linux.vanilla-2.6.23rc1-mm1/include/linux/libata.h	2007-07-26 15:02:58.000000000 +0100
+++ linux-2.6.23rc1-mm1/include/linux/libata.h	2007-07-26 15:37:59.000000000 +0100
@@ -883,6 +916,12 @@
 				  ATA_TIMING_CYCLE | ATA_TIMING_UDMA,
 };
 
+/* libata-acpi.c */
+#ifdef CONFIG_ATA_ACPI
+extern int ata_acpi_cbl_80wire(struct ata_port *ap);
+#else
+static inline int ata_acpi_cbl_80wire(struct ata_port *ap) { return 0; }
+#endif
 
 #ifdef CONFIG_PCI
 struct pci_bits {

Re: [PATCH 1/4] libata: ACPI checks for 80wire cable

[Jeff Garzik]

Alan Cox wrote:
> We can use the ACPI mode information with several drivers as a hint to
> cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then
> we know the BIOS thinks there are 80wire cables. If it doesn't set such a
> mode or it has no ACPI method then we get no further information and can
> rely on existing approaches
> 
> Introduce the function headers needed. Null it out for non ACPI boxes
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

I like this patchset.

This is the direction we need to be following.

	Jeff

Re: [PATCH 1/4] libata: ACPI checks for 80wire cable

[Jeff Garzik]

Alan Cox wrote:
> We can use the ACPI mode information with several drivers as a hint to
> cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then
> we know the BIOS thinks there are 80wire cables. If it doesn't set such a
> mode or it has no ACPI method then we get no further information and can
> rely on existing approaches
> 
> Introduce the function headers needed. Null it out for non ACPI boxes
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

applied 1-2, after combining into a single changeset.

When adding a new API, IMO it's better to keep definition and 
implementation additions in a single changeset.