From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, akpm@osdl.org, jeff@garzik.org
Subject: Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly
Date: Fri, 17 Aug 2007 19:41:47 +0400 [thread overview]
Message-ID: <46C5C1BB.5020802@ru.mvista.com> (raw)
In-Reply-To: <200708112337.48458.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
>>>@@ -117,8 +118,9 @@
>>> int arttim = arttim_port[ap->port_no][adev->devno];
>>> int drwtim = drwtim_port[ap->port_no][adev->devno];
>>>
>>>-
>>>- if (ata_timing_compute(adev, adev->pio_mode, &t, T, 0) < 0) {
>>>+ /* ata_timing_compute is smart and will produce timings for MWDMA
>>>+ that don't violate the drives PIO capabilities. */
>>>+ if (ata_timing_compute(adev, mode, &t, T, 0) < 0) {
>>> printk(KERN_ERR DRV_NAME ": mode computation failed.\n");
>>> return;
>>> }
>> That function rocks (except I didn't get what the address setup timings
>>mean to SW/MW DMA)...
> JFYI: this function was "borrowed" from drivers/ide/ide-timing.h,
> you can use it in IDE host drivers as well... ;)
Heh, I know. What I don't know is where to borrow the time for doing
this... :-/
> Bart
MBR, Sergei
next prev parent reply other threads:[~2007-08-17 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 13:33 [PATCH] pata_cmd64x: Set up MWDMA modes properly Alan Cox
2007-08-11 19:56 ` Sergei Shtylyov
2007-08-11 20:44 ` Alan Cox
2007-08-17 15:39 ` Sergei Shtylyov
2007-08-11 21:37 ` Bartlomiej Zolnierkiewicz
2007-08-17 15:41 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-09 23:09 Mikael Pettersson
2007-08-09 23:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C5C1BB.5020802@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).