From: Tejun Heo <htejun@gmail.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream-fixes 2/2] libata: prevent EH from being scheduled after port is detached
Date: Mon, 20 Aug 2007 21:27:35 +0900 [thread overview]
Message-ID: <46C988B7.8030408@gmail.com> (raw)
In-Reply-To: <20070820115356.GB2909@htj.dyndns.org>
Tejun Heo wrote:
> SCSI EH thread is stopped during SCSI host release which can happen
> after ATA host detach and free. This leads to the following oops.
>
> general protection fault: 0000 [1] PREEMPT SMP
> CPU 0
> Modules linked in: ahci libata
> Pid: 98, comm: kblockd/0 Not tainted 2.6.23-rc2-work #19
> RIP: 0010:[<ffffffff80242aa7>] [<ffffffff80242aa7>] run_workqueue+0xb7/0x190
> RSP: 0018:ffff81001fd2be80 EFLAGS: 00010087
> RAX: 6b6b6b6b6b6b6b6b RBX: ffff81001fae4a18 RCX: 1240000000000000
> RDX: 6b6b6b6b6b6b6b6b RSI: 9200000000000000 RDI: ffff81001fc1b930
> RBP: ffff81001fd2beb0 R08: fffffffffedc0049 R09: 0000000000000000
> R10: ffffffff80242a09 R11: 0000000000000000 R12: ffff81001fae4a10
> R13: ffff81001fc1b930 R14: 6b6b6b6b6b6b6b6b R15: ffff81001fc1b960
> FS: 0000000000000000(0000) GS:ffffffff808cb000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> CR2: 00002b531964d890 CR3: 0000000000201000 CR4: 00000000000006e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Process kblockd/0 (pid: 98, threadinfo ffff81001fd2a000, task ffff81001fe78140)
> Stack: ffff81001fd2beb0 ffff81001fc1b970 ffff81001fc1b930 ffff81001fd2bec0
> ffff81001fc1b960 0000000000000000 ffff81001fd2bf10 ffffffff8024385a
> 0000000000000000 ffff81001fe78140 ffffffff80247450 ffff81001fd2bed8
> Call Trace:
> [<ffffffff8024385a>] worker_thread+0xca/0x130
> [<ffffffff80247450>] autoremove_wake_function+0x0/0x40
> [<ffffffff80243790>] worker_thread+0x0/0x130
> [<ffffffff8024706d>] kthread+0x4d/0x80
> [<ffffffff8020cbf8>] child_rip+0xa/0x12
> [<ffffffff8020c2e0>] restore_args+0x0/0x30
> [<ffffffff80247178>] kthreadd+0xd8/0x160
> [<ffffffff80247020>] kthread+0x0/0x80
> [<ffffffff8020cbee>] child_rip+0x0/0x12
>
> This patch clears ATA_PFLAG_RUNNING after final freeze and moves
> ATA_PFLAG_RUNNING check into ata_eh_set_pending() to cover all EH
> schedule functions.
Oops, please hold a bit. After 30min of testing, it happened again. It
seems it needs more fixing. I'll write when I know more.
Thanks.
--
tejun
prev parent reply other threads:[~2007-08-20 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 11:50 [PATCH #upstream-fixes 1/2] libata: invert ATA_PFLAG_INITIALIZING to RUNNING Tejun Heo
2007-08-20 11:53 ` [PATCH #upstream-fixes 2/2] libata: prevent EH from being scheduled after port is detached Tejun Heo
2007-08-20 12:27 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C988B7.8030408@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).