* [PATCH #upstream-fixes] libata: don't check n_sectors during revalidation if zero
@ 2007-08-17 9:46 Tejun Heo
2007-08-23 9:34 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-08-17 9:46 UTC (permalink / raw)
To: Jeff Garzik, Alan Cox, linux-ide
If the initial configuration fails early, n_sectors is left at zero.
Checking against it during revalidation makes retried configuration
fail due to n_sectors mismatch. Ignore zero n_sectors during
revalidation.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: work/drivers/ata/libata-core.c
===================================================================
--- work.orig/drivers/ata/libata-core.c
+++ work/drivers/ata/libata-core.c
@@ -3700,7 +3700,8 @@ int ata_dev_revalidate(struct ata_device
goto fail;
/* verify n_sectors hasn't changed */
- if (dev->class == ATA_DEV_ATA && dev->n_sectors != n_sectors) {
+ if (dev->class == ATA_DEV_ATA && n_sectors &&
+ dev->n_sectors != n_sectors) {
ata_dev_printk(dev, KERN_INFO, "n_sectors mismatch "
"%llu != %llu\n",
(unsigned long long)n_sectors,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream-fixes] libata: don't check n_sectors during revalidation if zero
2007-08-17 9:46 [PATCH #upstream-fixes] libata: don't check n_sectors during revalidation if zero Tejun Heo
@ 2007-08-23 9:34 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-08-23 9:34 UTC (permalink / raw)
To: Tejun Heo; +Cc: Alan Cox, linux-ide
Tejun Heo wrote:
> If the initial configuration fails early, n_sectors is left at zero.
> Checking against it during revalidation makes retried configuration
> fail due to n_sectors mismatch. Ignore zero n_sectors during
> revalidation.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-23 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-17 9:46 [PATCH #upstream-fixes] libata: don't check n_sectors during revalidation if zero Tejun Heo
2007-08-23 9:34 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).