From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] libata-core: Allow translation setting to fail
Date: Fri, 31 Aug 2007 03:38:51 -0400
Message-ID: <46D7C58B.8020009@garzik.org>
References: <20070808142849.7927173d@the-village.bc.nu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from srv5.dvmed.net ([207.36.208.214]:51085 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752660AbXHaHix (ORCPT <rfc822;linux-ide@vger.kernel.org>);
	Fri, 31 Aug 2007 03:38:53 -0400
In-Reply-To: <20070808142849.7927173d@the-village.bc.nu>
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org

Alan Cox wrote:
> On some early drives (pre ATA1) this feature is not supported. If it
> fails then we know the drive geometry is the hardware geometry and the
> one we tried to set anyway so just carry on.
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c linux-2.6.23rc1-mm1/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c	2007-07-26 15:02:57.000000000 +0100
> +++ linux-2.6.23rc1-mm1/drivers/ata/libata-core.c	2007-08-08 13:38:39.257549616 +0100
> @@ -4081,6 +4170,11 @@
>  	tf.device |= (heads - 1) & 0x0f; /* max head = num. of heads - 1 */
>  
>  	err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0);
> +	/* A clean abort indicates an original or just out of spec drive
> +	   and we should continue as we issue the setup based on the
> +	   drive reported working geometry */
> +	if (err_mask == AC_ERR_DEV && (tf.feature & ATA_ABORTED))
> +		err_mask &= ~AC_ERR_DEV;

applied, after changing the above quoted line to 'err_mask = 0'.