Re: [PATCH libata-dev#upstream 3/3 REGENERATED] libata: implement and use ata_port_desc() to report port configuration

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> Currently, port configuration reporting has the following problems.
> 
> * iomapped address is reported instead of raw address
> * report contains irrelevant fields or lacks necessary fields for
>   non-SFF controllers.
> * host->irq/irq2 are there just for reporting and hacky.
> 
> This patch implements and uses ata_port_desc() and
> ata_port_pbar_desc().  ata_port_desc() is almost identical to
> ata_ehi_push_desc() except that it takes @ap instead of @ehi, has no
> locking requirement, can only be used during host initialization and "
> " is used as separator instead of ", ".  ata_port_pbar_desc() is a
> helper to ease reporting of a PCI BAR or an offsetted address into it.
> 
> LLD pushes whatever description it wants using the above two
> functions.  The accumulated description is printed on host
> registration after "[S/P]ATA max MAX_XFERMODE ".
> 
> SFF init helpers and ata_host_activate() automatically add
> descriptions for addresses and irq respectively, so only LLDs which
> isn't standard SFF need to add custom descriptions.  In many cases,
> such controllers need to report different things anyway.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Regenerated against the current #upstream (41b135c7).

applied