From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, mikpe@it.uu.se
Subject: Re: [PATCH libata-dev#upstream REGENERATED] libata: move EH repeat reporting into ata_eh_report()
Date: Fri, 31 Aug 2007 05:35:53 -0400 [thread overview]
Message-ID: <46D7E0F9.7080107@garzik.org> (raw)
In-Reply-To: <20070818042849.GE8590@htj.dyndns.org>
Tejun Heo wrote:
> EH is sometimes repeated without any error or action. For example,
> this happens when probing IDENTIFY fails because of a phantom device.
> In these cases, all the repeated EH does is making sure there is no
> unhandled error or pending action and return. This repeation is
> necessary to avoid losing any event which occurred while EH was in
> progress.
>
> Unfortunately, this dry run causes annonying "EH pending after
> completion" message. This patch moves the repeat reporting into
> ata_eh_report() such that it's more compact and skipped on dry runs.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Mikael Pettersson <mikep@it.uu.se>
> ---
> Regenerated against #upstream (41b135c7) +
> implement-and-use-ata_port_desc patch.
>
> drivers/ata/libata-eh.c | 30 ++++++++++++++++++------------
> include/linux/libata.h | 5 +++--
> 2 files changed, 21 insertions(+), 14 deletions(-)
applied
next prev parent reply other threads:[~2007-08-31 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 7:42 [PATCH libata-dev#upstream 1/2] libata: don't skip EH report if action is pending Tejun Heo
2007-07-31 7:51 ` [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report() Tejun Heo
2007-08-15 8:52 ` Jeff Garzik
2007-08-18 4:28 ` [PATCH libata-dev#upstream REGENERATED] " Tejun Heo
2007-08-31 9:35 ` Jeff Garzik [this message]
2007-08-01 5:56 ` [PATCH libata-dev#upstream 1/2] libata: don't skip EH report if action is pending Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D7E0F9.7080107@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).