Re: [PATCH] ahci.c: fix ati sb600 sata IRQ_TF_ERR

Re: [PATCH] ahci.c: fix ati sb600 sata IRQ_TF_ERR

[Tejun Heo]

[restoring cc list, please don't drop them]

Andreas John wrote:
> Hi,
> sorry for replying not quicker, but I just wanted to re-test all the
> theories.
> 
> 1. I was not able to reproduce the problem with 2.6.22 ubuntu gutsy
> (amd64 and i386). I ran checkarray --all many many times together with
> dds, but didnt tigger the bug. (even with a second new board!)
> 
> 2. The only explaination I have is that the sata connector on the HDD
> itself had some "plaque" on it (production?)
> 
> 3. The 1.5GB Sata jumper made no difference - that was our 1st try.

Hmmm.... Well, probably caused by faulty hardware or cosmic rays. :-P

> 4. I think the board can do MSI, as the test above shows

Not sure.  IRQ messages don't seem to indicate MSI is in use.  Have you
enabled it in the kernel config?

> 5. I still dont know _why_ the problem ocurred. By now I have about 5
> machines in production - no crash. Another two observations:
>   a) If mdX is sync'ing, the machines somestimes locks up for 5-100 secs

Does kernel say anything during this lock up?

>   b) If you hotplug a hdd (pull out) you get a sata "frozen" line in the
> log. Then e.g. md0 sets the disk to faulty, but the same disk (other
> partition) is still marked active on md1. It gets removeed, on 1st
> access on md1. Is that the intended behavior? Or should I file a bug?
> Where? Neil?

Currently, there's no mechanism to notify unplug to md inside the
kernel.  It can probably done via udev trick or some such.  Cc'd Neil
for advice.

Thanks.

-- 
tejun