From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag Date: Sat, 08 Sep 2007 12:42:52 -0400 Message-ID: <46E2D10C.40304@garzik.org> References: <200709052352.57848.bzolnier@gmail.com> <20070906081356.GA20007@havoc.gtf.org> <20070908161755.10902b54@the-village.bc.nu> <46E2BCA8.30402@garzik.org> <20070908162729.0f203af5@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:54555 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbXIHQmz (ORCPT ); Sat, 8 Sep 2007 12:42:55 -0400 In-Reply-To: <20070908162729.0f203af5@the-village.bc.nu> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, Mark Lord Alan Cox wrote: >>> You'd have to add the drain data on error hack first, right now we will >>> reset in that case (which for one or two devices has another problem in >>> that it won't clear a stuck FIFO) >> Nod. There was nothing ever wrong with Mark's drain patch, I just never >> saw a solid justification for it outside of root > > You don't need to be root, any user can do this with the right commands > via SG_IO - and it happens on errors occassionally for real. Which commands? Jeff