From: Tejun Heo <htejun@gmail.com>
To: Tom Evans <tom@23palmer.net>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: Port Multiplier Patch 2.6.22.1 on Alpha
Date: Sat, 08 Sep 2007 22:52:37 +0200 [thread overview]
Message-ID: <46E30B95.10806@gmail.com> (raw)
In-Reply-To: <46D64AAA.7090808@23palmer.net>
Tom Evans wrote:
> In sil24_config_port, the writel's for /* zero error counters */ should
> be writew's - they are 16bit control registers.
> Only PORT_DECODE_ERR_THRESH and PORT_CRC_ERR_THRESH appear to be
> unaligned, but why risk a stl when a stw (on platforms that support it)
> can be used.
That part of the code was taken verbatim from the Silicon Image sample
driver, which I'm sure have been tested only on x86s. Those error
threshold feature isn't really used and using writew's should be fine.
Do things work better after changing to writew's?
--
tejun
next prev parent reply other threads:[~2007-09-08 20:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 3:25 Port Multiplier Patch 2.6.22.1 on Alpha Tom Evans
2007-08-30 4:07 ` Jeff Garzik
2007-08-30 4:42 ` Tom Evans
2007-09-08 20:52 ` Tejun Heo [this message]
[not found] ` <46E3706A.3040102@23palmer.net>
2007-09-09 7:12 ` Tejun Heo
2007-09-01 3:04 ` Tom Evans
2007-09-08 4:32 ` Tom Evans
2007-09-08 4:34 ` Tom Evans
2007-09-08 4:37 ` Tom Evans
2007-09-08 4:40 ` Tom Evans
2007-09-08 4:41 ` Tom Evans
2007-09-08 5:01 ` Tom Evans
2007-09-08 20:53 ` Tejun Heo
[not found] ` <46E37154.9010007@23palmer.net>
2007-09-09 7:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E30B95.10806@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tom@23palmer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).