From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_acpi: Use ata_sff_port_start
Date: Thu, 20 Sep 2007 15:47:05 -0400 [thread overview]
Message-ID: <46F2CE39.6090403@garzik.org> (raw)
In-Reply-To: <20070920150415.542a3f49@the-village.bc.nu>
Alan Cox wrote:
> Purely a stylistic issue currently but best done while I notice it.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
> --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 15:32:51.000000000 +0100
> +++ linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 16:18:12.000000000 +0100
> @@ -270,7 +270,7 @@
> acpi->mask[0] = pacpi_discover_modes(ap, &ap->device[0]);
> acpi->mask[1] = pacpi_discover_modes(ap, &ap->device[1]);
>
> - ret = ata_port_start(ap);
> + ret = ata_sff_port_start(ap);
> if (ret < 0)
I request that somebody send me the pata_acpi driver against
netdev-2.6.git#upstream as an "add driver" patch, complete with all the
changes so far rolled into a single patch...
next prev parent reply other threads:[~2007-09-20 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:04 [PATCH] pata_acpi: Use ata_sff_port_start Alan Cox
2007-09-20 19:47 ` Jeff Garzik [this message]
2007-09-20 20:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2CE39.6090403@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).