* [PATCH] pata_acpi: Use ata_sff_port_start
@ 2007-09-20 14:04 Alan Cox
2007-09-20 19:47 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2007-09-20 14:04 UTC (permalink / raw)
To: akpm, jeff, linux-ide
Purely a stylistic issue currently but best done while I notice it.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
--- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 15:32:51.000000000 +0100
+++ linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 16:18:12.000000000 +0100
@@ -270,7 +270,7 @@
acpi->mask[0] = pacpi_discover_modes(ap, &ap->device[0]);
acpi->mask[1] = pacpi_discover_modes(ap, &ap->device[1]);
- ret = ata_port_start(ap);
+ ret = ata_sff_port_start(ap);
if (ret < 0)
return ret;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_acpi: Use ata_sff_port_start
2007-09-20 14:04 [PATCH] pata_acpi: Use ata_sff_port_start Alan Cox
@ 2007-09-20 19:47 ` Jeff Garzik
2007-09-20 20:27 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-09-20 19:47 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-ide
Alan Cox wrote:
> Purely a stylistic issue currently but best done while I notice it.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
> --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 15:32:51.000000000 +0100
> +++ linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 16:18:12.000000000 +0100
> @@ -270,7 +270,7 @@
> acpi->mask[0] = pacpi_discover_modes(ap, &ap->device[0]);
> acpi->mask[1] = pacpi_discover_modes(ap, &ap->device[1]);
>
> - ret = ata_port_start(ap);
> + ret = ata_sff_port_start(ap);
> if (ret < 0)
I request that somebody send me the pata_acpi driver against
netdev-2.6.git#upstream as an "add driver" patch, complete with all the
changes so far rolled into a single patch...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_acpi: Use ata_sff_port_start
2007-09-20 19:47 ` Jeff Garzik
@ 2007-09-20 20:27 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2007-09-20 20:27 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Alan Cox, linux-ide
On Thu, 20 Sep 2007 15:47:05 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> Alan Cox wrote:
> > Purely a stylistic issue currently but best done while I notice it.
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
> >
> > diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c
> > --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 15:32:51.000000000 +0100
> > +++ linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c 2007-09-18 16:18:12.000000000 +0100
> > @@ -270,7 +270,7 @@
> > acpi->mask[0] = pacpi_discover_modes(ap, &ap->device[0]);
> > acpi->mask[1] = pacpi_discover_modes(ap, &ap->device[1]);
> >
> > - ret = ata_port_start(ap);
> > + ret = ata_sff_port_start(ap);
> > if (ret < 0)
>
> I request that somebody send me the pata_acpi driver against
> netdev-2.6.git#upstream as an "add driver" patch, complete with all the
> changes so far rolled into a single patch...
>
umm, I guess that would be me. Will try to get onto that today or tomorrow..
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-20 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-20 14:04 [PATCH] pata_acpi: Use ata_sff_port_start Alan Cox
2007-09-20 19:47 ` Jeff Garzik
2007-09-20 20:27 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).