From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata-sff: Fix documentation Date: Thu, 20 Sep 2007 15:59:20 -0400 Message-ID: <46F2D118.4040609@garzik.org> References: <20070920150307.6b89238b@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:38528 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314AbXITT7X (ORCPT ); Thu, 20 Sep 2007 15:59:23 -0400 In-Reply-To: <20070920150307.6b89238b@the-village.bc.nu> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: akpm@osdl.org, linux-ide@vger.kernel.org Alan Cox wrote: > Code moved to ioread/iowrite but the comment didn't > Also note a posting issue > > Signed-off-by: Alan Cox > > diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c linux-2.6.23rc6-mm1/drivers/ata/libata-sff.c > --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c 2007-09-18 15:32:51.000000000 +0100 > +++ linux-2.6.23rc6-mm1/drivers/ata/libata-sff.c 2007-09-18 16:18:05.000000000 +0100 > @@ -257,7 +261,7 @@ > dmactl = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD); > iowrite8(dmactl | ATA_DMA_START, ap->ioaddr.bmdma_addr + ATA_DMA_CMD); > > - /* Strictly, one may wish to issue a readb() here, to > + /* Strictly, one may wish to issue an ioread8() here, to > * flush the mmio write. However, control also passes > * to the hardware at this point, and it will interrupt > * us when we are to resume control. So, in effect, > @@ -267,6 +271,9 @@ > * is expected, so I think it is best to not add a readb() > * without first all the MMIO ATA cards/mobos. > * Or maybe I'm just being paranoid. > + * > + * FIXME: The posting of this write means I/O starts are > + * unneccessarily delayed for MMIO applied