* [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
@ 2007-09-21 7:29 Tejun Heo
2007-09-21 10:41 ` Alan Cox
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tejun Heo @ 2007-09-21 7:29 UTC (permalink / raw)
To: Jeff Garzik, linux-ide, desaster.area, alan, bzolnier
sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
missing udma timing value for UDMA100. According to sis5513, this
should be 0x8000. This caused UDMA100 device to fail on pata_sis till
it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
Reported by Adam Blech.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Adam Blech <desaster.area@addcom.de>
---
drivers/ata/pata_sis.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index da3f720..3b5be77 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -376,8 +376,9 @@ static void sis_66_set_dmamode (struct ata_port *ap, struct ata_device *adev)
int drive_pci = sis_old_port_base(adev);
u16 timing;
+ /* MWDMA 0-2 and UDMA 0-5 */
const u16 mwdma_bits[] = { 0x008, 0x302, 0x301 };
- const u16 udma_bits[] = { 0xF000, 0xD000, 0xB000, 0xA000, 0x9000};
+ const u16 udma_bits[] = { 0xF000, 0xD000, 0xB000, 0xA000, 0x9000, 0x8000 };
pci_read_config_word(pdev, drive_pci, &timing);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
2007-09-21 10:41 ` Alan Cox
@ 2007-09-21 10:38 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2007-09-21 10:38 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, linux-ide, desaster.area, alan, bzolnier
Alan Cox wrote:
> On Fri, 21 Sep 2007 16:29:05 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
>> sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
>> missing udma timing value for UDMA100. According to sis5513, this
>> should be 0x8000. This caused UDMA100 device to fail on pata_sis till
>> it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
>>
>> Reported by Adam Blech.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Cc: Adam Blech <desaster.area@addcom.de>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> I was just looking at this as we had a Red Hat bug for it 8)
>
I caught this one from a SUSE bug. I guess distros are useful from time
to time. :-)
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
2007-09-21 7:29 [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode() Tejun Heo
@ 2007-09-21 10:41 ` Alan Cox
2007-09-21 10:38 ` Tejun Heo
2007-09-25 22:06 ` Chuck Ebbert
2007-09-26 1:39 ` Jeff Garzik
2 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2007-09-21 10:41 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-ide, desaster.area, alan, bzolnier
On Fri, 21 Sep 2007 16:29:05 +0900
Tejun Heo <htejun@gmail.com> wrote:
> sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
> missing udma timing value for UDMA100. According to sis5513, this
> should be 0x8000. This caused UDMA100 device to fail on pata_sis till
> it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
>
> Reported by Adam Blech.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Adam Blech <desaster.area@addcom.de>
Acked-by: Alan Cox <alan@redhat.com>
I was just looking at this as we had a Red Hat bug for it 8)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
2007-09-21 7:29 [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode() Tejun Heo
2007-09-21 10:41 ` Alan Cox
@ 2007-09-25 22:06 ` Chuck Ebbert
2007-09-26 1:39 ` Jeff Garzik
2 siblings, 0 replies; 5+ messages in thread
From: Chuck Ebbert @ 2007-09-25 22:06 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-ide, desaster.area, alan, bzolnier
On 09/21/2007 03:29 AM, Tejun Heo wrote:
> sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
> missing udma timing value for UDMA100. According to sis5513, this
> should be 0x8000. This caused UDMA100 device to fail on pata_sis till
> it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
>
> Reported by Adam Blech.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Adam Blech <desaster.area@addcom.de>
> ---
> drivers/ata/pata_sis.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
> index da3f720..3b5be77 100644
> --- a/drivers/ata/pata_sis.c
> +++ b/drivers/ata/pata_sis.c
> @@ -376,8 +376,9 @@ static void sis_66_set_dmamode (struct ata_port *ap, struct ata_device *adev)
> int drive_pci = sis_old_port_base(adev);
> u16 timing;
>
> + /* MWDMA 0-2 and UDMA 0-5 */
> const u16 mwdma_bits[] = { 0x008, 0x302, 0x301 };
> - const u16 udma_bits[] = { 0xF000, 0xD000, 0xB000, 0xA000, 0x9000};
> + const u16 udma_bits[] = { 0xF000, 0xD000, 0xB000, 0xA000, 0x9000, 0x8000 };
>
> pci_read_config_word(pdev, drive_pci, &timing);
>
Is this going into 2.6.23?
It's not in 2.6.23-rc8-mm1...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
2007-09-21 7:29 [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode() Tejun Heo
2007-09-21 10:41 ` Alan Cox
2007-09-25 22:06 ` Chuck Ebbert
@ 2007-09-26 1:39 ` Jeff Garzik
2 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2007-09-26 1:39 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, desaster.area, alan, bzolnier
Tejun Heo wrote:
> sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
> missing udma timing value for UDMA100. According to sis5513, this
> should be 0x8000. This caused UDMA100 device to fail on pata_sis till
> it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
>
> Reported by Adam Blech.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Adam Blech <desaster.area@addcom.de>
> ---
> drivers/ata/pata_sis.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-26 1:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-21 7:29 [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode() Tejun Heo
2007-09-21 10:41 ` Alan Cox
2007-09-21 10:38 ` Tejun Heo
2007-09-25 22:06 ` Chuck Ebbert
2007-09-26 1:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).