From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH UPDATED #upstream-fixes,#upstream] sata_sil24: fix IRQ clearing race when PCIX_IRQ_WOC is used
Date: Tue, 25 Sep 2007 21:39:18 -0400 [thread overview]
Message-ID: <46F9B846.7000505@garzik.org> (raw)
In-Reply-To: <20070923033705.GJ10660@htj.dyndns.org>
Tejun Heo wrote:
> When PCIX_IRQ_WOC is used, sil24 has an inherent race condition
> between clearing IRQ pending and reading IRQ status. If IRQ pending
> is cleared after reading IRQ status, there's possibility of lost IRQ.
> If IRQ pending is cleared before reading IRQ status, spurious IRQs
> will occur.
>
> sata_sil24 till now cleared IRQ pending after reading IRQ status thus
> losing IRQs on machines where PCIX_IRQ_WOC was used. Reverse the
> order and ignore spurious IRQs if PCIX_IRQ_WOC.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> The previous patch contained a stupid mistake. This is the correct
> one.
>
> drivers/ata/sata_sil24.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
applied
prev parent reply other threads:[~2007-09-26 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 3:26 [PATCH #upstream-fixes,#upstream] sata_sil24: fix IRQ clearing race when PCIX_IRQ_WOC is used Tejun Heo
2007-09-23 3:37 ` [PATCH UPDATED " Tejun Heo
2007-09-26 1:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F9B846.7000505@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).