From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_via: kill SATA_PATA_SHARING register handling
Date: Tue, 25 Sep 2007 22:27:21 -0400 [thread overview]
Message-ID: <46F9C389.400@garzik.org> (raw)
In-Reply-To: <20070921085544.GE10660@htj.dyndns.org>
Tejun Heo wrote:
> The SATA_PATA_SHARING register doesn't have anything to do with the
> SATA part of the controller. It indicates whether an extern SATA PHY
> is attached to the PATA part of the controller and if so how it is
> wired. As the PATA part is driven by pata_via, sata_via has no reason
> to care about that. Also, pata_via should work fine under all
> configurations.
>
> This patch removes unnecessary attach failures. It seems recent via
> chipsets are defaulting to different values or are actually connected
> to SATA PHY triggering this more often.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/sata_via.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
applied to #upstream
prev parent reply other threads:[~2007-09-26 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 8:55 [PATCH] sata_via: kill SATA_PATA_SHARING register handling Tejun Heo
2007-09-26 2:27 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F9C389.400@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).