* [patch] SB700 contains more than one IDE channel [not found] <FFECF24D2A7F6D418B9511AF6F3586020209802C@shacnexch2.atitech.com> @ 2007-09-27 9:04 ` Shane Huang 2007-09-27 12:18 ` Sergei Shtylyov 2007-10-01 21:04 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 4+ messages in thread From: Shane Huang @ 2007-09-27 9:04 UTC (permalink / raw) To: bzolnier; +Cc: linux-ide, gregkh, Su, Henry, Shane Huang [-- Attachment #1: Type: text/plain, Size: 1308 bytes --] From: shane.huang@amd.com SB700 supports one physical IDE channel, but SB700 SATA controller supports combined mode. When the SATA combined mode is enabled, two SATA ports(port4 and port5) share one IDE channel from IDE controller, and PATA will share the other IDE channel. Our previous patch adding SB700 IDE device ID only support one IDE channel, which contains bug. The attached patch fix the bug. Signed-off-by: shane.huang@amd.com ---------------------------------------------- diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c linux-2.6.23-rc5/drivers/ide/pci/atiixp.c --- linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c 2007-09-01 14:08:24.000000000 +0800 +++ linux-2.6.23-rc5/drivers/ide/pci/atiixp.c 2007-09-28 00:35:55.000000000 +0800 @@ -325,7 +325,7 @@ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, - { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { 0, }, }; MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl); [-- Attachment #2: SB700_2_IDE_Channels.patch --] [-- Type: application/octet-stream, Size: 780 bytes --] diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c linux-2.6.23-rc5/drivers/ide/pci/atiixp.c --- linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c 2007-09-01 14:08:24.000000000 +0800 +++ linux-2.6.23-rc5/drivers/ide/pci/atiixp.c 2007-09-28 00:35:55.000000000 +0800 @@ -325,7 +325,7 @@ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, - { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { 0, }, }; MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] SB700 contains more than one IDE channel 2007-09-27 9:04 ` [patch] SB700 contains more than one IDE channel Shane Huang @ 2007-09-27 12:18 ` Sergei Shtylyov 2007-09-28 3:44 ` Shane Huang 2007-10-01 21:04 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 4+ messages in thread From: Sergei Shtylyov @ 2007-09-27 12:18 UTC (permalink / raw) To: Shane Huang, bzolnier; +Cc: linux-ide, gregkh, Su, Henry Hello. Shane Huang wrote: > SB700 supports one physical IDE channel, but SB700 SATA controller > supports combined mode. When the SATA combined mode is enabled, > two SATA ports(port4 and port5) share one IDE channel from IDE > controller, and PATA will share the other IDE channel. > Our previous patch adding SB700 IDE device ID only support one > IDE channel, which contains bug. The attached patch fix the bug. > Signed-off-by: shane.huang@amd.com Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > ---------------------------------------------- > diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c > linux-2.6.23-rc5/drivers/ide/pci/atiixp.c > --- linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c 2007-09-01 > 14:08:24.000000000 +0800 > +++ linux-2.6.23-rc5/drivers/ide/pci/atiixp.c 2007-09-28 > 00:35:55.000000000 +0800 > @@ -325,7 +325,7 @@ > { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, > PCI_ANY_ID, 0, 0, 0}, > { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, > PCI_ANY_ID, 0, 0, 0}, > { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, > PCI_ANY_ID, 0, 0, 1}, > - { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, > PCI_ANY_ID, 0, 0, 1}, > + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, > PCI_ANY_ID, 0, 0, 0}, > { 0, }, > }; > MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl); The inlined patch has suffered from word wrapping, and the attached one luckily didn't; yet the attachment has a wrong MIME type -- patches should be text/plain. MBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [patch] SB700 contains more than one IDE channel 2007-09-27 12:18 ` Sergei Shtylyov @ 2007-09-28 3:44 ` Shane Huang 0 siblings, 0 replies; 4+ messages in thread From: Shane Huang @ 2007-09-28 3:44 UTC (permalink / raw) To: Sergei Shtylyov, bzolnier; +Cc: linux-ide, gregkh, Su, Henry, Shane Huang Hi Sergei: Thanks for your reply. > The inlined patch has suffered from word wrapping, OK, I think the cause is my mail client MS outlook's setting. I try to change my outlook settings and attach the patch again at the end of this mail. Please check it again. > and the attached one > luckily didn't; yet the attachment has a wrong MIME type -- patches should be > text/plain. As to this case, I don't know why. The patch was generated with diff on linux, and copied to my windows mail machine to be sent. All my previous patches with the same method do NOT meet such problem. So if the patch in this mail does not work either, would you please help to change and apply it for me? So that we can save some time, otherwise I'll have to try to use gmail to send it at home. Thanks Best Regards Shane Signed-off-by: shane.huang@amd.com ---------------------------------------------- diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c linux-2.6.23-rc5/drivers/ide/pci/atiixp.c --- linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c 2007-09-01 14:08:24.000000000 +0800 +++ linux-2.6.23-rc5/drivers/ide/pci/atiixp.c 2007-09-28 00:35:55.000000000 +0800 @@ -325,7 +325,7 @@ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, - { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1}, + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { 0, }, }; MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] SB700 contains more than one IDE channel 2007-09-27 9:04 ` [patch] SB700 contains more than one IDE channel Shane Huang 2007-09-27 12:18 ` Sergei Shtylyov @ 2007-10-01 21:04 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2007-10-01 21:04 UTC (permalink / raw) To: Shane Huang; +Cc: linux-ide, gregkh, Su, Henry On Thursday 27 September 2007, Shane Huang wrote: > From: shane.huang@amd.com > > SB700 supports one physical IDE channel, but SB700 SATA controller > supports combined mode. When the SATA combined mode is enabled, > two SATA ports(port4 and port5) share one IDE channel from IDE > controller, and PATA will share the other IDE channel. > > Our previous patch adding SB700 IDE device ID only support one > IDE channel, which contains bug. The attached patch fix the bug. > > > Signed-off-by: shane.huang@amd.com applied The inlined patch was word-wrapped and the attached one lacked patch description so manual fixing was required anyway. Not a big problem but next time please try to use some known-to-be-good mail client to inline patches. Thanks, Bart ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-01 21:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <FFECF24D2A7F6D418B9511AF6F3586020209802C@shacnexch2.atitech.com>
2007-09-27 9:04 ` [patch] SB700 contains more than one IDE channel Shane Huang
2007-09-27 12:18 ` Sergei Shtylyov
2007-09-28 3:44 ` Shane Huang
2007-10-01 21:04 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).