From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: Stardom SATA HSM violation Date: Thu, 27 Sep 2007 19:42:21 -0400 Message-ID: <46FC3FDD.5060201@pobox.com> References: <46CFA08E.6090604@arbores.ca> <6bffcb0e0708261610g10d9c59ck5789fac6feca9f42@mail.gmail.com> <46DBCB6C.8080206@gmail.com> <20070905095327.6277d054.akpm@linux-foundation.org> <46DEE617.4050004@rtr.ca> <46E0A253.7060803@gmail.com> <46E154DE.2060602@rtr.ca> <46FB563A.80108@gmail.com> <20070927193701.6230d77f@the-village.bc.nu> <46FC3D7D.90009@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:59786 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759342AbXI0Xmg (ORCPT ); Thu, 27 Sep 2007 19:42:36 -0400 In-Reply-To: <46FC3D7D.90009@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Alan Cox , Mark Lord , Andrew Morton , michal.k.k.piotrowski@gmail.com, bryan@arbores.ca, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Tejun Heo wrote: > Alan Cox wrote: >>> I think there have been enough cases where this draining was necessary. >>> IIRC, ata_piix was involved in those cases, right? If so, can you >>> please submit a patch which applies this only to affected controllers? >>> I don't feel too confident about applying this to all SFF controllers. >> Old IDE does it on all controllers bar a couple. So we have a very good >> knowledge of what does/doesn't work. The one that needs care in old ide >> is an ordering issue where a state machine reset done first causes the >> drain of the I/O to hang. > > Hmmm... So, do we apply draining to all PATA? Or is ata_piix SATA > affected too? I would think all SFF controllers, since a lot of first gen SATA are really bridged solutions. If they are flagging DRQ, I say oblige them :) Jeff