From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Mark Lord <liml@rtr.ca>,
Andrew Morton <akpm@linux-foundation.org>,
michal.k.k.piotrowski@gmail.com, bryan@arbores.ca,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: Stardom SATA HSM violation
Date: Thu, 27 Sep 2007 16:52:28 -0700 [thread overview]
Message-ID: <46FC423C.2050206@gmail.com> (raw)
In-Reply-To: <46FC3FDD.5060201@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Alan Cox wrote:
>>>> I think there have been enough cases where this draining was necessary.
>>>> IIRC, ata_piix was involved in those cases, right? If so, can you
>>>> please submit a patch which applies this only to affected controllers?
>>>> I don't feel too confident about applying this to all SFF controllers.
>>> Old IDE does it on all controllers bar a couple. So we have a very good
>>> knowledge of what does/doesn't work. The one that needs care in old ide
>>> is an ordering issue where a state machine reset done first causes the
>>> drain of the I/O to hang.
>>
>> Hmmm... So, do we apply draining to all PATA? Or is ata_piix SATA
>> affected too?
>
> I would think all SFF controllers, since a lot of first gen SATA are
> really bridged solutions. If they are flagging DRQ, I say oblige them :)
Alright, then the posted patch should be good enough. Mark, can you be
bothered to regenerate the patch and post it one more time (again)? It
seems we all agree the update is needed.
Thanks a lot.
--
tejun
next prev parent reply other threads:[~2007-09-27 23:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46CFA08E.6090604@arbores.ca>
2007-08-26 23:10 ` Stardom SATA HSM violation Michal Piotrowski
2007-09-03 8:53 ` Tejun Heo
2007-09-05 16:53 ` Andrew Morton
2007-09-05 17:23 ` Mark Lord
2007-09-05 19:38 ` Andrew Morton
2007-09-05 23:03 ` Mark Lord
2007-09-07 0:58 ` Tejun Heo
2007-09-07 13:40 ` Mark Lord
2007-09-27 7:05 ` Tejun Heo
2007-09-27 18:37 ` Alan Cox
2007-09-27 23:32 ` Tejun Heo
2007-09-27 23:42 ` Jeff Garzik
2007-09-27 23:52 ` Tejun Heo [this message]
2007-09-28 3:56 ` [PATCH] libata drain fifo on stuck DRQ " Mark Lord
2007-09-28 9:48 ` Tejun Heo
2007-09-28 9:56 ` Andrew Morton
2007-09-28 10:01 ` Tejun Heo
2007-09-28 10:27 ` Alan Cox
2007-09-28 13:41 ` [PATCH] libata drain fifo on stuck DRQ HSM violation (try#2) Mark Lord
2007-09-29 6:24 ` Jeff Garzik
2007-09-29 1:05 ` [PATCH] libata drain fifo on stuck DRQ HSM violation Jeff Garzik
2007-09-29 6:28 ` Alan Cox
2007-09-29 12:34 ` Mark Lord
2007-09-28 3:52 ` Stardom SATA " Mark Lord
2007-09-06 15:00 ` Bryan Woods
2007-09-07 0:58 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FC423C.2050206@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bryan@arbores.ca \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).