From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, akpm@osdl.org, jeff@garzik.org
Subject: Re: [PATCH] Fix HPA handling regression
Date: Fri, 28 Sep 2007 06:31:29 -0700 [thread overview]
Message-ID: <46FD0231.2020002@gmail.com> (raw)
In-Reply-To: <20070926180222.10a96afe@the-village.bc.nu>
Alan Cox wrote:
> Restore the support for handling drives that report one sector too many
> (ie SCSI not ATA style). This worked before the HPA update but was
> removed in that process
>
> Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: Tejun Heo <htejun@gmail.com>
> diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/include/linux/libata.h linux-2.6.23rc8-mm1/include/linux/libata.h
> --- linux.vanilla-2.6.23rc8-mm1/include/linux/libata.h 2007-09-26 16:46:57.844875296 +0100
> +++ linux-2.6.23rc8-mm1/include/linux/libata.h 2007-09-26 17:11:56.215088400 +0100
> @@ -315,7 +315,8 @@
> ATA_HORKAGE_NONCQ = (1 << 2), /* Don't use NCQ */
> ATA_HORKAGE_MAX_SEC_128 = (1 << 3), /* Limit max sects to 128 */
> ATA_HORKAGE_BROKEN_HPA = (1 << 4), /* Broken HPA */
> - ATA_HORKAGE_DRQ = (1 << 5), /* Device forgets to clear DRQ on error */
> + ATA_HORKAGE_HPA_SIZE = (1 << 5), /* Reports native size off by one */
> + ATA_HORKAGE_DRQ = (1 << 6), /* Device forgets to clear DRQ on error */
>
> /* DMA mask for user DMA control: User visible values do not
> renumber */
But Jeff might not like adding new constant and shifting the existing
one at the same time.
--
tejun
next prev parent reply other threads:[~2007-09-28 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 17:02 [PATCH] Fix HPA handling regression Alan Cox
2007-09-28 13:31 ` Tejun Heo [this message]
2007-09-29 1:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FD0231.2020002@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).