linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	michal.k.k.piotrowski@gmail.com, bryan@arbores.ca,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata drain fifo on stuck DRQ HSM violation
Date: Sat, 29 Sep 2007 08:34:18 -0400	[thread overview]
Message-ID: <46FE464A.4020808@rtr.ca> (raw)
In-Reply-To: <20070929072831.2df5f5ed@the-village.bc.nu>

Alan Cox wrote:
>>> Why 512 words ?
>> Though I have queued Mark's patch to be applied, my gut feeling would 
>> lean towards a single DRQ block, rather than 512.
> 
> Why not just work from the old IDE code.
>>
>>>>  	ata_altstatus(ap);
>>>> -	ata_chk_status(ap);
>>>> +	ata_drain_fifo(ap, qc);
>>> ap->ops->cleanup();
>>>
>>> might be wiser
>> If someone needs that, they can override the error handler with their 
>> own.  No need for a new op.
> 
> PDC202xx needs

Alan, you're the expert there (my condolences!).
Can you generate a fix for the PDC202xx to go with this?

Cheers

  reply	other threads:[~2007-09-29 12:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46CFA08E.6090604@arbores.ca>
2007-08-26 23:10 ` Stardom SATA HSM violation Michal Piotrowski
2007-09-03  8:53   ` Tejun Heo
2007-09-05 16:53     ` Andrew Morton
2007-09-05 17:23       ` Mark Lord
2007-09-05 19:38         ` Andrew Morton
2007-09-05 23:03           ` Mark Lord
2007-09-07  0:58         ` Tejun Heo
2007-09-07 13:40           ` Mark Lord
2007-09-27  7:05             ` Tejun Heo
2007-09-27 18:37               ` Alan Cox
2007-09-27 23:32                 ` Tejun Heo
2007-09-27 23:42                   ` Jeff Garzik
2007-09-27 23:52                     ` Tejun Heo
2007-09-28  3:56                       ` [PATCH] libata drain fifo on stuck DRQ " Mark Lord
2007-09-28  9:48                         ` Tejun Heo
2007-09-28  9:56                           ` Andrew Morton
2007-09-28 10:01                             ` Tejun Heo
2007-09-28 10:27                         ` Alan Cox
2007-09-28 13:41                           ` [PATCH] libata drain fifo on stuck DRQ HSM violation (try#2) Mark Lord
2007-09-29  6:24                             ` Jeff Garzik
2007-09-29  1:05                           ` [PATCH] libata drain fifo on stuck DRQ HSM violation Jeff Garzik
2007-09-29  6:28                             ` Alan Cox
2007-09-29 12:34                               ` Mark Lord [this message]
2007-09-28  3:52                   ` Stardom SATA " Mark Lord
2007-09-06 15:00     ` Bryan Woods
2007-09-07  0:58       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FE464A.4020808@rtr.ca \
    --to=liml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bryan@arbores.ca \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).