From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44ECCC433E0 for ; Tue, 2 Feb 2021 10:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FFD764E2C for ; Tue, 2 Feb 2021 10:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbhBBKew (ORCPT ); Tue, 2 Feb 2021 05:34:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54449 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhBBKer (ORCPT ); Tue, 2 Feb 2021 05:34:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612261995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C6EnQJADAEP2un65IiO+7dRtagMmN96hqQ78sKe3a4Q=; b=FntAkiX3mx6zZOEmSXrqm280k+0nOg7UYJoZ+Y6EjEzAJSGP7Q83SKM8EIbrpyZ94K5t6G o4GdL80lJxZuDGIxpyMXn6tiAfNIMFtbMG9q1zsINNJlNvYc+LTqDF38yLbkCsJMtUqtQX uEu95WrsX7c4wyuUzvcMrtfK21R5GMM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-C4Ov9mwPNJ2oPl00tKzUwQ-1; Tue, 02 Feb 2021 05:33:13 -0500 X-MC-Unique: C4Ov9mwPNJ2oPl00tKzUwQ-1 Received: by mail-ej1-f71.google.com with SMTP id ia14so2035543ejc.8 for ; Tue, 02 Feb 2021 02:33:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C6EnQJADAEP2un65IiO+7dRtagMmN96hqQ78sKe3a4Q=; b=qBHEIMIL530DuzeZhd1hQp8+W0wdMAggBHbBYgpbqXZ6rRKeLPu6iVU/8HXdO0KKjm /avGlO0r19vcCYLUH/k5j+wKrfv2dxQIS3FnkTo31UQl8CkMygwodoUJHp2jJMUYxgOi tJ3xS0aBb+TQMUm5jSavc5QGNFqLV1mWzutVgRrBcBgNDCU1DHQUTfoMIy3KcAfHsUs+ g1BGvOHi1DhHcBq99TtpHRe7hS5+ENXMtv0v28lEjRmlV/iEl1hfaUyJByZvRei+YKUp lpKNNwi7MaOiYUfs6wJQuPilwwaFM/rSofBKHdbsLQAe6WyVO/KVgrVt/tsJOOLRDGbZ kvhg== X-Gm-Message-State: AOAM533pHVooRqlkCAtzbAOpAdMypWso5gtF/hNBdSkkOAMoCZwl2waM Dqp3WKJlLU4HqlTqyrOlVjnFlbLyjPcNwlToyNs4Rn24UW2VBpWCFKA0LBW34x4IbbOc8W3ZqpL 8kfH8UBwAO8y6efy25Gvc X-Received: by 2002:aa7:d817:: with SMTP id v23mr244384edq.192.1612261992222; Tue, 02 Feb 2021 02:33:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwO7SkdS0Kh/9ftpeXXLbdVTYwB8pnZ9oCQOs4Xht2tgKobWoIStyU859GpT+RaJFXfaPRYWA== X-Received: by 2002:aa7:d817:: with SMTP id v23mr244371edq.192.1612261992084; Tue, 02 Feb 2021 02:33:12 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id x17sm9690450edd.76.2021.02.02.02.33.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 02:33:11 -0800 (PST) Subject: Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller) To: Pavel Machek Cc: Jens Axboe , Dan Murphy , linux-ide@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210112223015.GB28214@duo.ucw.cz> <0ec34bca-f7e0-8954-c253-d07ed6b71b80@redhat.com> <20210127220134.GC23419@amd> <20210202093228.GA29131@amd> From: Hans de Goede Message-ID: <46bcf09c-c4ac-e96b-1813-1798d36cd93d@redhat.com> Date: Tue, 2 Feb 2021 11:33:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210202093228.GA29131@amd> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi, On 2/2/21 10:32 AM, Pavel Machek wrote: > Hi! > >>> Is it a regression? AFAIK it is a bug that has been there >>> forever... My original plan was to simply wait for 5.12, so it gets >>> full release of testing... >> >> It may have been a pre-existing bug which got triggered by libata >> changes? > > Fixes tag suggests it is rather old. > >> I don't know. I almost always run all my locally build kernels with lockdep >> enabled and as the maintainer of the vboxvideo, vboxguest and vboxsf guest >> drivers in the mainline kernel I quite often boot local build kernels inside >> a vm. >> >> So I believe that lockdep tripping over this is new in 5.11, which is why >> I called it a regression. >> >> And the fix seems very safe and simple, so IMHO it would be good to get >> this into 5.11 > > It is in 5.11 now, and also -stable kernels. (Which suprised me a > bit). > > Testing would be welcome. I've been running my locally build kernels with this patch added for a while now. Including inside VirtualBox where the bug triggered before. I've not seen any bad side-effects from having this patch in my local kernels and I can confirm that it fixes the issue which I was seeing. Regards, Hans