linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 12/15] ide: remove ->dma_master field from ide_hwif_t
Date: Mon, 01 Oct 2007 17:48:35 -0400	[thread overview]
Message-ID: <47016B33.9010001@garzik.org> (raw)
In-Reply-To: <200710012339.39304.bzolnier@gmail.com>

Bartlomiej Zolnierkiewicz wrote:
> * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use
>   pci_resource_start(hwif->pci_dev, 4) instead of hwif->dma_master.

Before using pci_resource_start(), the code should check 
pci_resource_len() to ensure it is the appropriate size.

It would be very wise to ensure that pci_resource_flags()&IORESOURCE_IO 
is true, too.

	Jeff




  reply	other threads:[~2007-10-01 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 21:39 [PATCH 12/15] ide: remove ->dma_master field from ide_hwif_t Bartlomiej Zolnierkiewicz
2007-10-01 21:48 ` Jeff Garzik [this message]
2007-10-01 22:06   ` Bartlomiej Zolnierkiewicz
2007-10-01 22:31     ` Jeff Garzik
2007-10-02 21:24       ` Bartlomiej Zolnierkiewicz
2007-10-03 12:50         ` Sergei Shtylyov
2007-10-03 22:27           ` Bartlomiej Zolnierkiewicz
2007-10-04 13:27           ` Sergei Shtylyov
2007-10-08 21:03             ` Bartlomiej Zolnierkiewicz
2007-10-18 17:08               ` Sergei Shtylyov
2007-10-24 21:24                 ` Bartlomiej Zolnierkiewicz
2007-10-25 15:01                   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47016B33.9010001@garzik.org \
    --to=jeff@garzik.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).