From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 12/15] ide: remove ->dma_master field from ide_hwif_t Date: Mon, 01 Oct 2007 18:31:56 -0400 Message-ID: <4701755C.4030906@garzik.org> References: <200710012339.39304.bzolnier@gmail.com> <47016B33.9010001@garzik.org> <200710020006.35156.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:33490 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbXJAWb6 (ORCPT ); Mon, 1 Oct 2007 18:31:58 -0400 In-Reply-To: <200710020006.35156.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > On Monday 01 October 2007, Jeff Garzik wrote: >> Bartlomiej Zolnierkiewicz wrote: >>> * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use >>> pci_resource_start(hwif->pci_dev, 4) instead of hwif->dma_master. >> Before using pci_resource_start(), the code should check >> pci_resource_len() to ensure it is the appropriate size. >> >> It would be very wise to ensure that pci_resource_flags()&IORESOURCE_IO >> is true, too. > > Sure but since the old code hasn't been doing these checks (old code > just did pci_resource_start() -> hwif->dma_base -> hwif->dma_master) > this is a separate issue from what the patch tries to achieve. Nonetheless this is duplicating an existing bug $N times... not ideal :) Jeff