From: Jeff Garzik <jeff@garzik.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
kristen.c.accardi@intel.com
Subject: Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4
Date: Tue, 02 Oct 2007 16:38:19 -0400 [thread overview]
Message-ID: <4702AC3B.2010004@garzik.org> (raw)
In-Reply-To: <47029423.6030605@garzik.org>
Jeff Garzik wrote:
> Matthew Garrett wrote:
>> Modern laptops with hotswap bays still tend to utilise a PATA
>> interface on a SATA bridge, generally with the host controller in some
>> legacy emulation mode rather than AHCI. This means that the existing
>> hotplug code in libata is unable to work. The ACPI specification
>> states that these devices can send notifications when hotswapped,
>> which avoids the need to obtain notification from the controller. This
>> patch uses the existing libata-acpi code and simply registers a
>> notification in order to trigger a rescan whenever the firmware
>> signals an event.
>>
>> Signed-off-by: Matthew Garrett
>> <mjg59@srcf.ucam.org>
>> ---
>>
>> This incorporates Jeff's feedback. sdev is checked for NULL, and
>> different notifications are registered for ap-level and dev-level
>> handlers. The core code is split out into a helper function called by
>> both of these. The other change is the removal of the extraneous
>> newline from the end of the notification event, to match the upstream
>> change in the bay driver.
>
> applied
Come on, dude! This doesn't even build:
UPD include/linux/compile.h
drivers/ata/libata-acpi.c: In function ‘ata_acpi_handle_hotplug’:
drivers/ata/libata-acpi.c:104: error: ‘struct ata_port’ has no member
named ‘eh_info’
drivers/ata/libata-acpi.c: In function ‘ata_acpi_dev_notify’:
drivers/ata/libata-acpi.c:130: error: ‘struct ata_device’ has no member
named ‘ap’
drivers/ata/libata-acpi.c: In function ‘ata_acpi_associate’:
drivers/ata/libata-acpi.c:178: error: implicit declaration of function
‘ata_port_max_devices’
drivers/ata/libata-acpi.c:179: error: ‘struct ata_port’ has no member
named ‘device’
make[2]: *** [drivers/ata/libata-acpi.o] Error 1
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-10-02 20:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 3:01 [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug Matthew Garrett
2007-09-15 17:06 ` [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2 Matthew Garrett
2007-09-16 12:22 ` Tejun Heo
2007-09-20 22:04 ` Jeff Garzik
2007-09-20 22:21 ` Matthew Garrett
2007-09-21 2:35 ` Tejun Heo
2007-09-21 2:42 ` Matthew Garrett
2007-09-21 2:53 ` Tejun Heo
2007-09-21 2:57 ` Matthew Garrett
2007-09-21 3:08 ` Tejun Heo
2007-09-21 3:12 ` Matthew Garrett
2007-09-21 3:19 ` Tejun Heo
2007-09-24 23:14 ` [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3 Matthew Garrett
2007-09-27 17:26 ` Kristen Carlson Accardi
2007-09-27 17:55 ` Matthew Garrett
2007-09-27 20:39 ` Henrique de Moraes Holschuh
2007-10-02 15:04 ` Jeff Garzik
2007-10-02 18:46 ` Matthew Garrett
2007-10-02 18:49 ` [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4 Matthew Garrett
2007-10-02 18:55 ` Jeff Garzik
2007-10-02 20:38 ` Jeff Garzik [this message]
2007-10-02 20:42 ` Matthew Garrett
2007-10-02 21:20 ` Matthew Garrett
2007-10-02 21:23 ` Jeff Garzik
2007-10-03 0:24 ` [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 5 Matthew Garrett
2007-10-03 20:27 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4702AC3B.2010004@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).