From: Jeff Garzik <jeff@garzik.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/15] qd65xx: fix deadlock on error handling
Date: Tue, 02 Oct 2007 18:19:05 -0400 [thread overview]
Message-ID: <4702C3D9.6040606@garzik.org> (raw)
In-Reply-To: <200710030015.44586.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
ACK everything else (that I snipped)...
> @@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv
>
> static int __init qd_testreg(int port)
> {
> + static DEFINE_SPINLOCK(qd65xx_lock);
> unsigned long flags;
> u8 savereg, readreg;
At this point, the lock is largely pointless, isn't it?
Seems like you might as well use local_irq_save/restore.
Jeff
next prev parent reply other threads:[~2007-10-02 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:33 [PATCH 3/15] qd65xx: fix deadlock on error handling Bartlomiej Zolnierkiewicz
2007-10-02 12:59 ` Sergei Shtylyov
2007-10-02 13:04 ` Jeff Garzik
2007-10-02 22:15 ` Bartlomiej Zolnierkiewicz
2007-10-02 22:19 ` Jeff Garzik [this message]
2007-10-03 22:41 ` Bartlomiej Zolnierkiewicz
2007-10-03 22:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4702C3D9.6040606@garzik.org \
--to=jeff@garzik.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).