From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 3/15] qd65xx: fix deadlock on error handling
Date: Tue, 02 Oct 2007 18:19:05 -0400
Message-ID: <4702C3D9.6040606@garzik.org>
References: <200710012333.02643.bzolnier@gmail.com> <470240BC.9070707@ru.mvista.com> <470241CD.4060507@garzik.org> <200710030015.44586.bzolnier@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-ide-owner@vger.kernel.org>
Received: from srv5.dvmed.net ([207.36.208.214]:47686 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751300AbXJBWTI (ORCPT <rfc822;linux-ide@vger.kernel.org>);
	Tue, 2 Oct 2007 18:19:08 -0400
In-Reply-To: <200710030015.44586.bzolnier@gmail.com>
Sender: linux-ide-owner@vger.kernel.org
List-Id: linux-ide@vger.kernel.org
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org

Bartlomiej Zolnierkiewicz wrote:

ACK everything else (that I snipped)...

> @@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv
>  
>  static int __init qd_testreg(int port)
>  {
> +	static DEFINE_SPINLOCK(qd65xx_lock);
>  	unsigned long flags;
>  	u8 savereg, readreg;

At this point, the lock is largely pointless, isn't it?

Seems like you might as well use local_irq_save/restore.

	Jeff