From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2/2] libata: change the last state of pio read to HSM_ST_IDLE
Date: Wed, 03 Oct 2007 14:16:14 -0400 [thread overview]
Message-ID: <4703DC6E.8040204@garzik.org> (raw)
In-Reply-To: <470316FE.2000406@tw.ibm.com>
Albert Lee wrote:
> Jeff Garzik wrote:
>> Albert Lee wrote:
>>
>>> Patch 2/2:
>>> After reading the last pio data block, the HSM is waiting for device
>>> to be idle, not waiting for the last interrupt.
>>>
>>> This patch changes the state after "PIO data-in" to HSM_ST_IDLE instead
>>> of HSM_ST_LAST for accuracy.
>>>
>>> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
>>
>> Is this still needed?
>>
>
> Not quite needed; it only makes the state transition after reading the
> last PIO block more accurate.
>
> However, if we want to do part of the irq PIO in the workqueue sometime
> in the future, this patch will be needed (otherwise the HSM might think
> it expecting another irq). For the time being, maybe we can just skip
> this patch until sometime it's really needed.
OK, thanks.
Jeff
prev parent reply other threads:[~2007-10-03 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 8:24 [PATCH 0/2] libata: minor pio fixes (resend) Albert Lee
2007-07-04 8:28 ` [PATCH 1/2] libata: move ata_altstatus() to pio data xfer functions Albert Lee
2007-08-15 7:19 ` Jeff Garzik
2007-07-04 8:33 ` [PATCH 2/2] libata: change the last state of pio read to HSM_ST_IDLE Albert Lee
2007-10-02 15:19 ` Jeff Garzik
2007-10-03 4:13 ` Albert Lee
2007-10-03 18:16 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4703DC6E.8040204@garzik.org \
--to=jeff@garzik.org \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).