From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Martin K. Petersen" <mkp@mkp.net>,
linux-ide@vger.kernel.org, info-linux@geode.amd.com
Subject: Re: [PATCH 1/1] pata_cs5536: ATA driver for Geode companion chip
Date: Wed, 03 Oct 2007 14:20:48 -0400 [thread overview]
Message-ID: <4703DD80.4030307@garzik.org> (raw)
In-Reply-To: <20071003192232.558ec72b@the-village.bc.nu>
Alan Cox wrote:
>> pata_cs5536.c relies on Geode Machine Specific Registers to configure
>> the ATA function and uses the correct PIO timings for the chip.
>>
>> Signed-off-by: Martin K. Petersen <mkp@mkp.net>
>
> I'm basically happy with this but would appreciate some feedback from AMD
> on the subject.
>
> (cc added therefore : info-linux@geode.amd.com)
>
>> + .qc_issue = ata_qc_issue_prot,
>
> The older AMD ex NS ex Cyrix chipsets mishandle 64K DMA blocks - is that
> the case for the CS5536 or not - does it consider a PRD entry with zero
> length as 64K or 0 bytes
Good point.
>> + if ((cfg & IDE_CFG_CHANEN) == 0) {
>> + printk(KERN_ERR "CS5536: disabled by BIOS\n");
>
> To save Jeff whining - he'll want that to be DRV_NAME or similar and to
> call it pata_cs5536
Now I'm embarrassed... I looked over the driver and missed this ;-) ;-)
Jeff
next prev parent reply other threads:[~2007-10-03 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 17:28 [PATCH 1/1] pata_cs5536: ATA driver for Geode companion chip Martin K. Petersen
2007-10-03 18:22 ` Alan Cox
2007-10-03 18:20 ` Jeff Garzik [this message]
2007-10-03 18:45 ` Martin K. Petersen
2007-10-03 18:51 ` Alan Cox
2007-10-03 20:31 ` Jordan Crouse
2007-10-03 20:59 ` Alan Cox
2007-10-03 21:18 ` Jordan Crouse
2007-10-03 22:32 ` Martin K. Petersen
2007-10-03 22:56 ` Jeff Garzik
2007-10-10 1:25 ` [PATCH 1/1] " Jeff Garzik
2007-10-10 4:33 ` Martin K. Petersen
2007-10-10 15:20 ` Jordan Crouse
2007-10-10 17:39 ` Andrew Paprocki
2007-10-11 7:22 ` Andrew Paprocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4703DD80.4030307@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=info-linux@geode.amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=mkp@mkp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).