* [patch 05/10] drivers/ata/pata_ixp4xx_cf.c: ioremap return code check
@ 2007-10-02 20:53 akpm
2007-10-03 18:44 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-10-02 20:53 UTC (permalink / raw)
To: jeff; +Cc: linux-ide, akpm, postfailathushmaildotcom, alan, htejun
From: Scott Thompson <postfailathushmaildotcom@yahoo.com>
Add missing ioremap return checks.
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
Acked-by: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/ata/pata_ixp4xx_cf.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN drivers/ata/pata_ixp4xx_cf.c~drivers-ata-pata_ixp4xx_cfc-ioremap-return-code-check drivers/ata/pata_ixp4xx_cf.c
--- a/drivers/ata/pata_ixp4xx_cf.c~drivers-ata-pata_ixp4xx_cfc-ioremap-return-code-check
+++ a/drivers/ata/pata_ixp4xx_cf.c
@@ -195,6 +195,9 @@ static __devinit int ixp4xx_pata_probe(s
data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
+ if (!data->cs0 || !data->cs1)
+ return -ENOMEM;
+
irq = platform_get_irq(pdev, 0);
if (irq)
set_irq_type(irq, IRQT_RISING);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 05/10] drivers/ata/pata_ixp4xx_cf.c: ioremap return code check
2007-10-02 20:53 [patch 05/10] drivers/ata/pata_ixp4xx_cf.c: ioremap return code check akpm
@ 2007-10-03 18:44 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-10-03 18:44 UTC (permalink / raw)
To: akpm; +Cc: linux-ide, postfailathushmaildotcom, alan, htejun
akpm@linux-foundation.org wrote:
> From: Scott Thompson <postfailathushmaildotcom@yahoo.com>
>
> Add missing ioremap return checks.
>
> Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
> Acked-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-03 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-02 20:53 [patch 05/10] drivers/ata/pata_ixp4xx_cf.c: ioremap return code check akpm
2007-10-03 18:44 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).