Re: [patch 01/10] pata_acpi: restore driver

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> --- /dev/null
> +++ a/drivers/ata/pata_acpi.c
> @@ -0,0 +1,403 @@
> +/*
> + *	ACPI PATA driver
> + *
> + *	(c) 2007 Red Hat  <alan@redhat.com>
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/pci.h>
> +#include <linux/init.h>
> +#include <linux/blkdev.h>
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <scsi/scsi_host.h>
> +#include <acpi/acpi_bus.h>
> +#include <acpi/acnames.h>
> +#include <acpi/acnamesp.h>
> +#include <acpi/acparser.h>
> +#include <acpi/acexcep.h>
> +#include <acpi/acmacros.h>
> +#include <acpi/actypes.h>
> +
> +#include <linux/libata.h>
> +#include <linux/ata.h>
> +
> +#include "libata-acpi.h"


Just to recap the conversion in IRC, this patch contains two fatal problems:

* libata-acpi.h was not included, thus it doesn't build

* it depends on non-existent symbol CONFIG_SATA_ACPI (should be 
CONFIG_ATA_ACPI), which also means it never gets built

So the ball and lyrics are back in Alan's court ;-)
(or should I say submarine back in Alan's coastal waters)

	Jeff