From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 7/8] ide: add IDE_HFLAG_NO_LBA48 and IDE_HFLAG_NO_LBA48_DMA host flags
Date: Thu, 04 Oct 2007 18:53:39 +0400 [thread overview]
Message-ID: <4704FE73.5010602@ru.mvista.com> (raw)
In-Reply-To: <200708271934.18313.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Add IDE_HFLAG_NO_LBA48[_DMA] host flags, use it instead of hwif->no_lba48[_dma]
> and then remove no longer needed hwif->no_lba48[_dma]. As a side-effect
> this change fixes hwif->no_lba48_dma not being restored by ide_hwif_restore().
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-probe.c
> ===================================================================
> --- a/drivers/ide/ide-probe.c
> +++ b/drivers/ide/ide-probe.c
> @@ -951,7 +951,8 @@ static int ide_init_queue(ide_drive_t *d
> blk_queue_segment_boundary(q, 0xffff);
>
> if (!hwif->rqsize) {
> - if (hwif->no_lba48 || hwif->no_lba48_dma)
> + if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
> + (hwif->host_flags & IDE_HFLAG_NO_LBA48_DMA))
Could have been:
if (hwif->host_flags &
(IDE_HFLAG_NO_LBA48_DMA | IDE_HFLAG_NO_LBA48_DMA))
MBR, Sergei
parent reply other threads:[~2007-10-04 14:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200708271934.18313.bzolnier@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4704FE73.5010602@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).