[PATCH #upstream] libata: blacklist NCQ on Seagate Barracuda ST380817AS

[PATCH #upstream] libata: blacklist NCQ on Seagate Barracuda ST380817AS

[Tejun Heo]

From: Paolo Ornati <ornati@fastwebnet.it>

Seagate Barracuda ST380817AS has troubles with NCQ. For example,
unpacking a tarball on an XFS filesystem gives this:

ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen
ata1.00: cmd 61/40:00:29:a3:98/00:00:00:00:00/40 tag 0 cdb 0x0 data 32768 out
         res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)

More info here:
http://lkml.org/lkml/2007/1/21/76
    
Blacklist it!

Signed-off-by: Paolo Ornati <ornati@fastwebnet.it>
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 drivers/ata/libata-core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index aecbdad..48a62a2 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3958,6 +3958,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "Maxtor 7V300F0",	"VA111630",	ATA_HORKAGE_NONCQ },
 	{ "HITACHI HDS7250SASUN500G*", NULL,    ATA_HORKAGE_NONCQ },
 	{ "HITACHI HDS7225SBSUN250G*", NULL,    ATA_HORKAGE_NONCQ },
+	{ "ST380817AS",		"3.42",		ATA_HORKAGE_NONCQ },
 
 	/* Blacklist entries taken from Silicon Image 3124/3132
 	   Windows driver .inf file - also several Linux problem reports */

Re: [PATCH #upstream] libata: blacklist NCQ on Seagate Barracuda ST380817AS

[Alan Cox]

On Thu, 4 Oct 2007 11:06:56 +0900
Tejun Heo <htejun@gmail.com> wrote:

> From: Paolo Ornati <ornati@fastwebnet.it>
> 
> Seagate Barracuda ST380817AS has troubles with NCQ. For example,
> unpacking a tarball on an XFS filesystem gives this:
> 
> ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen
> ata1.00: cmd 61/40:00:29:a3:98/00:00:00:00:00/40 tag 0 cdb 0x0 data 32768 out
>          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)

Looking at this and our NCQ code I don't see any provision for drive
unfairness in our code. If we continue to issue commands to the drive I'm
not seeing where we guarantee a given command will ever complete rather
than being deferred forever by a dumb drive - which some SCSI drives also
will do...

Re: [PATCH #upstream] libata: blacklist NCQ on Seagate Barracuda ST380817AS

[Tejun Heo]

Alan Cox wrote:
> On Thu, 4 Oct 2007 11:06:56 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> From: Paolo Ornati <ornati@fastwebnet.it>
>>
>> Seagate Barracuda ST380817AS has troubles with NCQ. For example,
>> unpacking a tarball on an XFS filesystem gives this:
>>
>> ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen
>> ata1.00: cmd 61/40:00:29:a3:98/00:00:00:00:00/40 tag 0 cdb 0x0 data 32768 out
>>          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
> 
> Looking at this and our NCQ code I don't see any provision for drive
> unfairness in our code. If we continue to issue commands to the drive I'm
> not seeing where we guarantee a given command will ever complete rather
> than being deferred forever by a dumb drive - which some SCSI drives also
> will do...

After several such timeouts, libata will turn off NCQ which should solve
the problem.

-- 
tejun

Re: [PATCH #upstream] libata: blacklist NCQ on Seagate Barracuda ST380817AS

[Jeff Garzik]

Tejun Heo wrote:
> From: Paolo Ornati <ornati@fastwebnet.it>
> 
> Seagate Barracuda ST380817AS has troubles with NCQ. For example,
> unpacking a tarball on an XFS filesystem gives this:
> 
> ata1.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen
> ata1.00: cmd 61/40:00:29:a3:98/00:00:00:00:00/40 tag 0 cdb 0x0 data 32768 out
>          res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
> 
> More info here:
> http://lkml.org/lkml/2007/1/21/76
>     
> Blacklist it!
> 
> Signed-off-by: Paolo Ornati <ornati@fastwebnet.it>
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied several of these