[PATCH 1/2] libata-core: Expose gtm methods for driver use

[PATCH 1/2] libata-core: Expose gtm methods for driver use

[Alan Cox]

Talk to the dark side our driver has to, yes. Much misleading is the
data. Store it in a structure we do so that it may be parsed.

Signed-off-by: Alan Cox <alan@redhat.com>
-- 
Whats small, old and shouts phrases out of order across mountains ?
Yodla..



diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index a276c06..43c4fd7 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -142,7 +142,7 @@ void ata_acpi_associate(struct ata_host 
  * RETURNS:
  * 0 on success, -ENOENT if _GTM doesn't exist, -errno on failure.
  */
-static int ata_acpi_gtm(const struct ata_port *ap, struct ata_acpi_gtm *gtm)
+int ata_acpi_gtm(const struct ata_port *ap, struct ata_acpi_gtm *gtm)
 {
 	struct acpi_buffer output = { .length = ACPI_ALLOCATE_BUFFER };
 	union acpi_object *out_obj;
@@ -186,6 +186,8 @@ static int ata_acpi_gtm(const struct ata
 	return rc;
 }
 
+EXPORT_SYMBOL_GPL(ata_acpi_gtm);
+
 /**
  * ata_acpi_stm - execute _STM
  * @ap: target ATA port
@@ -199,7 +201,7 @@ static int ata_acpi_gtm(const struct ata
  * RETURNS:
  * 0 on success, -ENOENT if _STM doesn't exist, -errno on failure.
  */
-static int ata_acpi_stm(const struct ata_port *ap, struct ata_acpi_gtm *stm)
+int ata_acpi_stm(const struct ata_port *ap, struct ata_acpi_gtm *stm)
 {
 	acpi_status status;
 	struct acpi_object_list         input;
@@ -231,6 +233,8 @@ static int ata_acpi_stm(const struct ata
 	return 0;
 }
 
+EXPORT_SYMBOL_GPL(ata_acpi_stm);
+
 /**
  * ata_dev_get_GTF - get the drive bootup default taskfile settings
  * @dev: target ATA device

diff --git a/include/linux/libata.h b/include/linux/libata.h
index 84dfc23..751aabc 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -929,6 +929,8 @@ enum {
 /* libata-acpi.c */
 #ifdef CONFIG_ATA_ACPI
 extern int ata_acpi_cbl_80wire(struct ata_port *ap);
+int ata_acpi_stm(const struct ata_port *ap, struct ata_acpi_gtm *stm);
+int ata_acpi_gtm(const struct ata_port *ap, struct ata_acpi_gtm *stm);
 #else
 static inline int ata_acpi_cbl_80wire(struct ata_port *ap) { return 0; }
 #endif

Re: [PATCH 1/2] libata-core: Expose gtm methods for driver use

[Jeff Garzik]

Alan Cox wrote:
> Talk to the dark side our driver has to, yes. Much misleading is the
> data. Store it in a structure we do so that it may be parsed.
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

applied 1-2