* [PATCH #upstream] pata_jmicron: match vendor and class code only
@ 2007-10-06 22:04 Tejun Heo
2007-10-06 22:46 ` Alan Cox
2007-10-10 1:32 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Tejun Heo @ 2007-10-06 22:04 UTC (permalink / raw)
To: Jeff Garzik, linux-ide, ethanhsiao, justin
PATA part of all current JMB controllers behave the same way and
JMicron confirms that all future ones will stay compatible. Drop
device matching and match only vendor and class.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Ethan Hsiao <ethanhsiao@jmicron.com>
Cc: Justin Tsai <justin@jmicron.com>
---
drivers/ata/pata_jmicron.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
index 6d5a818..225a722 100644
--- a/drivers/ata/pata_jmicron.c
+++ b/drivers/ata/pata_jmicron.c
@@ -204,17 +204,8 @@ static int jmicron_init_one (struct pci_dev *pdev, const struct pci_device_id *i
}
static const struct pci_device_id jmicron_pci_tbl[] = {
- { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB361,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 361 },
- { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB363,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 363 },
- { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB365,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 365 },
- { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB366,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 366 },
- { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB368,
- PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 368 },
-
+ { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
+ PCI_CLASS_STORAGE_IDE << 8, 0xffff00, 0 },
{ } /* terminate list */
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH #upstream] pata_jmicron: match vendor and class code only
2007-10-06 22:04 [PATCH #upstream] pata_jmicron: match vendor and class code only Tejun Heo
@ 2007-10-06 22:46 ` Alan Cox
2007-10-10 1:32 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-10-06 22:46 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-ide, ethanhsiao, justin
On Sun, 7 Oct 2007 07:04:50 +0900
Tejun Heo <htejun@gmail.com> wrote:
> PATA part of all current JMB controllers behave the same way and
> JMicron confirms that all future ones will stay compatible. Drop
> device matching and match only vendor and class.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Ethan Hsiao <ethanhsiao@jmicron.com>
> Cc: Justin Tsai <justin@jmicron.com>
Acked-by: Alan Cox <alan@redhat.com>
Tho if I was Jmicron I'd specifc ids 0x0XXX or similar to be safe, but
hey its not my product 8)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH #upstream] pata_jmicron: match vendor and class code only
2007-10-06 22:04 [PATCH #upstream] pata_jmicron: match vendor and class code only Tejun Heo
2007-10-06 22:46 ` Alan Cox
@ 2007-10-10 1:32 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-10-10 1:32 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, ethanhsiao, justin
Tejun Heo wrote:
> PATA part of all current JMB controllers behave the same way and
> JMicron confirms that all future ones will stay compatible. Drop
> device matching and match only vendor and class.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Ethan Hsiao <ethanhsiao@jmicron.com>
> Cc: Justin Tsai <justin@jmicron.com>
> ---
> drivers/ata/pata_jmicron.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-10 1:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-06 22:04 [PATCH #upstream] pata_jmicron: match vendor and class code only Tejun Heo
2007-10-06 22:46 ` Alan Cox
2007-10-10 1:32 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).