* [PATCH] libata: skip suppress reporting if ATA_EHI_QUIET
@ 2007-10-09 5:57 Tejun Heo
2007-10-10 1:40 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-10-09 5:57 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ATA_EHI_NO_AUTOPSY and ATA_EHI_QUIET are used during initial probing
to skip exception analysis and reporting. Usually, there's nothing to
report but on some allowed but rare corner cases (e.g. phy status
changed interrupt when IRQ is enabled on frozen port - this happens if
IRQ pending status isn't cleared in the IRQ router or controller)
exception messages get printed.
Skip reporting if ATA_EHI_QUIET is set.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-eh.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 0bd3898..866ac9d 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1868,6 +1868,9 @@ static void ata_eh_link_report(struct ata_link *link)
char tries_buf[6];
int tag, nr_failed = 0;
+ if (ehc->i.flags & ATA_EHI_QUIET)
+ return;
+
desc = NULL;
if (ehc->i.desc[0] != '\0')
desc = ehc->i.desc;
--
1.5.0.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: skip suppress reporting if ATA_EHI_QUIET
2007-10-09 5:57 [PATCH] libata: skip suppress reporting if ATA_EHI_QUIET Tejun Heo
@ 2007-10-10 1:40 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-10-10 1:40 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> ATA_EHI_NO_AUTOPSY and ATA_EHI_QUIET are used during initial probing
> to skip exception analysis and reporting. Usually, there's nothing to
> report but on some allowed but rare corner cases (e.g. phy status
> changed interrupt when IRQ is enabled on frozen port - this happens if
> IRQ pending status isn't cleared in the IRQ router or controller)
> exception messages get printed.
>
> Skip reporting if ATA_EHI_QUIET is set.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-10 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-09 5:57 [PATCH] libata: skip suppress reporting if ATA_EHI_QUIET Tejun Heo
2007-10-10 1:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).