From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, ballen@gravity.phys.uwm.edu,
andrew@ishiboo.com
Subject: Re: [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete()
Date: Fri, 12 Oct 2007 08:13:11 -0400 [thread overview]
Message-ID: <470F64D7.9040604@garzik.org> (raw)
In-Reply-To: <20071012115631.GA11510@htj.dyndns.org>
Tejun Heo wrote:
> Some commands need post-processing after successful completion. This
> was done in ata_scsi_qc_complete() till now but command post
> processing doesn't belong to SAT layer. Move them to
> __ata_qc_complete() and, while at it, restructure a bit to ease adding
> post-processing for other commands.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
BTW, while doing the TEST UNIT READY emulation patch for ATA (recently
withdrawn from libata-dev.git#upstream), I found a problem with the
interface that was difficult to get around: TEST UNIT READY simulation
code really wants to look at the result TF of CHECK POWER MODE, even if
ATA_ERR is asserted, before determining whether or not to call that
command an error.
Maybe the EH scheduling could be moved until after ->complete_fn, to
permit ->complete_fn users to manipulate qc->err_mask etc.?
Jeff
next prev parent reply other threads:[~2007-10-12 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 11:56 [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete() Tejun Heo
2007-10-12 11:56 ` [PATCH #upstream 2/2] libata: track SLEEP state and issue SRST to wake it up Tejun Heo
2007-10-13 4:57 ` Andrew Paprocki
2007-10-13 13:55 ` Tejun Heo
2007-10-14 1:02 ` Andrew Paprocki
2007-10-12 12:13 ` Jeff Garzik [this message]
2007-10-13 13:09 ` [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete() Tejun Heo
2007-10-18 1:23 ` Jeff Garzik
2007-10-18 3:55 ` Bruce Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470F64D7.9040604@garzik.org \
--to=jeff@garzik.org \
--cc=andrew@ishiboo.com \
--cc=ballen@gravity.phys.uwm.edu \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).