From: Jeff Garzik <jeff@garzik.org>
To: Kuan Luo <kluo@nvidia.com>
Cc: Zoltan Boszormenyi <zboszor@dunaweb.hu>,
akpm@linux-foundation.org, Peer Chen <pchen@nvidia.com>,
Robert Hancock <hancockr@shaw.ca>,
linux-ide@vger.kernel.org
Subject: Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61
Date: Fri, 12 Oct 2007 17:15:46 -0400 [thread overview]
Message-ID: <470FE402.8080105@garzik.org> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B059FE1AE@hkemmail01.nvidia.com>
Kuan Luo wrote:
> One idea, only simply adding
> if (!swncq_enabled)
> nv_port_info[SWNCQ].flags &= ~ATA_FLAG_NCQ;
>
> ppi[0] = &nv_port_info[type];
> rc = ata_pci_prepare_sff_host(pdev, ppi, &host);
>
> I don't know if this is appropriate
As long as the structure is not read-only ('const'), that is OK.
And just for future reference, make sure you're aware of the
implications of this applying to all sata_nv-aware PCI IDs. If you
present multiple SATA devices on a PCI bus, or have multiple PCI cards
(rare in NV's case, I guess) the probe function will be called multiple
times. You might even want to put that code into the module init
function, rather than the probe function.
Jeff
next prev parent reply other threads:[~2007-10-12 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 20:59 [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61 akpm
2007-09-20 22:40 ` Jeff Garzik
2007-09-21 5:54 ` Zoltan Boszormenyi
2007-09-21 8:04 ` Zoltan Boszormenyi
2007-09-26 3:48 ` Jeff Garzik
2007-09-26 5:36 ` Zoltan Boszormenyi
2007-09-26 5:38 ` Jeff Garzik
2007-09-26 5:46 ` Zoltan Boszormenyi
2007-09-27 6:12 ` Kuan Luo
2007-09-27 6:19 ` Jeff Garzik
2007-09-27 6:56 ` Kuan Luo
2007-09-27 7:10 ` Jeff Garzik
2007-09-27 7:33 ` Kuan Luo
2007-09-27 8:54 ` Kuan Luo
2007-10-04 6:31 ` Peer Chen
2007-10-12 21:15 ` Jeff Garzik [this message]
2007-10-14 12:29 ` Kuan Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470FE402.8080105@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=zboszor@dunaweb.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).