* [PATCH] ide: fix serverworks.c UDMA regression
@ 2007-10-15 19:05 Tony Battersby
2007-10-16 19:25 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 5+ messages in thread
From: Tony Battersby @ 2007-10-15 19:05 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, linux-ide
The patch described by the following excerpt from ChangeLog-2.6.22 makes
it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
commit 2d5eaa6dd744a641e75503232a01f52d0768884c
Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Thu May 10 00:01:08 2007 +0200
ide: rework the code for selecting the best DMA transfer mode (v3)
...
This one-line patch against 2.6.23 fixes the problem.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
--- linux-2.6.23/drivers/ide/pci/serverworks.c.orig 2007-10-15 12:15:01.000000000 -0400
+++ linux-2.6.23/drivers/ide/pci/serverworks.c 2007-10-15 13:47:29.000000000 -0400
@@ -97,6 +97,7 @@ static u8 svwks_udma_filter(ide_drive_t
mode = 2;
switch(mode) {
+ case 3: mask = 0x3f; break;
case 2: mask = 0x1f; break;
case 1: mask = 0x07; break;
default: mask = 0x00; break;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ide: fix serverworks.c UDMA regression
2007-10-15 19:05 [PATCH] ide: fix serverworks.c UDMA regression Tony Battersby
@ 2007-10-16 19:25 ` Bartlomiej Zolnierkiewicz
2007-11-13 23:28 ` [stable] " Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-16 19:25 UTC (permalink / raw)
To: Tony Battersby; +Cc: linux-ide, stable
On Monday 15 October 2007, Tony Battersby wrote:
> The patch described by the following excerpt from ChangeLog-2.6.22 makes
> it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
>
> commit 2d5eaa6dd744a641e75503232a01f52d0768884c
> Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Thu May 10 00:01:08 2007 +0200
>
> ide: rework the code for selecting the best DMA transfer mode (v3)
>
> ...
>
> This one-line patch against 2.6.23 fixes the problem.
Thanks!! (and sorry for the bug)
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
applied
Greg/Chris: this is a perfect candidate for 2.6.23.2
> ---
> --- linux-2.6.23/drivers/ide/pci/serverworks.c.orig 2007-10-15 12:15:01.000000000 -0400
> +++ linux-2.6.23/drivers/ide/pci/serverworks.c 2007-10-15 13:47:29.000000000 -0400
> @@ -97,6 +97,7 @@ static u8 svwks_udma_filter(ide_drive_t
> mode = 2;
>
> switch(mode) {
> + case 3: mask = 0x3f; break;
> case 2: mask = 0x1f; break;
> case 1: mask = 0x07; break;
> default: mask = 0x00; break;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable] [PATCH] ide: fix serverworks.c UDMA regression
2007-10-16 19:25 ` Bartlomiej Zolnierkiewicz
@ 2007-11-13 23:28 ` Greg KH
2007-11-14 14:34 ` Tony Battersby
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2007-11-13 23:28 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Tony Battersby, linux-ide, stable
On Tue, Oct 16, 2007 at 09:25:41PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Monday 15 October 2007, Tony Battersby wrote:
> > The patch described by the following excerpt from ChangeLog-2.6.22 makes
> > it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
> >
> > commit 2d5eaa6dd744a641e75503232a01f52d0768884c
> > Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Date: Thu May 10 00:01:08 2007 +0200
> >
> > ide: rework the code for selecting the best DMA transfer mode (v3)
> >
> > ...
> >
> > This one-line patch against 2.6.23 fixes the problem.
>
> Thanks!! (and sorry for the bug)
>
> > Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
>
> applied
>
> Greg/Chris: this is a perfect candidate for 2.6.23.2
Thanks, got it now.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] [PATCH] ide: fix serverworks.c UDMA regression
2007-11-13 23:28 ` [stable] " Greg KH
@ 2007-11-14 14:34 ` Tony Battersby
2007-11-14 16:55 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Tony Battersby @ 2007-11-14 14:34 UTC (permalink / raw)
To: Greg KH; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, stable
Greg KH wrote:
> On Tue, Oct 16, 2007 at 09:25:41PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
>> On Monday 15 October 2007, Tony Battersby wrote:
>>
>>> The patch described by the following excerpt from ChangeLog-2.6.22 makes
>>> it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
>>>
>>> commit 2d5eaa6dd744a641e75503232a01f52d0768884c
>>> Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>> Date: Thu May 10 00:01:08 2007 +0200
>>>
>>> ide: rework the code for selecting the best DMA transfer mode (v3)
>>>
>>> ...
>>>
>>> This one-line patch against 2.6.23 fixes the problem.
>>>
>> Thanks!! (and sorry for the bug)
>>
>>
>>> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
>>>
>> applied
>>
>> Greg/Chris: this is a perfect candidate for 2.6.23.2
>>
>
> Thanks, got it now.
>
> greg k-h
>
>
Also applies to 2.6.22, if you are still maintaining that stable branch.
Thanks,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] [PATCH] ide: fix serverworks.c UDMA regression
2007-11-14 14:34 ` Tony Battersby
@ 2007-11-14 16:55 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2007-11-14 16:55 UTC (permalink / raw)
To: Tony Battersby; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, stable
On Wed, Nov 14, 2007 at 09:34:47AM -0500, Tony Battersby wrote:
> Greg KH wrote:
> > On Tue, Oct 16, 2007 at 09:25:41PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> >> On Monday 15 October 2007, Tony Battersby wrote:
> >>
> >>> The patch described by the following excerpt from ChangeLog-2.6.22 makes
> >>> it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
> >>>
> >>> commit 2d5eaa6dd744a641e75503232a01f52d0768884c
> >>> Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >>> Date: Thu May 10 00:01:08 2007 +0200
> >>>
> >>> ide: rework the code for selecting the best DMA transfer mode (v3)
> >>>
> >>> ...
> >>>
> >>> This one-line patch against 2.6.23 fixes the problem.
> >>>
> >> Thanks!! (and sorry for the bug)
> >>
> >>
> >>> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> >>>
> >> applied
> >>
> >> Greg/Chris: this is a perfect candidate for 2.6.23.2
> >>
> >
> > Thanks, got it now.
> >
> > greg k-h
> >
> >
>
> Also applies to 2.6.22, if you are still maintaining that stable branch.
Thanks, yes, I am, in fact it's already in my todo-22 directory which
I'll get to after cleaning out this HUGE backlog of .23 patches that
I've been slack on attending to :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-14 17:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 19:05 [PATCH] ide: fix serverworks.c UDMA regression Tony Battersby
2007-10-16 19:25 ` Bartlomiej Zolnierkiewicz
2007-11-13 23:28 ` [stable] " Greg KH
2007-11-14 14:34 ` Tony Battersby
2007-11-14 16:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).