From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-core: Drop in the final bit of IORDY handling
Date: Tue, 16 Oct 2007 00:32:35 +0400 [thread overview]
Message-ID: <4713CE63.2010006@ru.mvista.com> (raw)
In-Reply-To: <20071015212502.73ffc51c@the-village.bc.nu>
Alan Cox wrote:
>>>+ /* Ancient devices may need us to avoid IORDY */
>>>+ if (ata_pio_need_iordy(dev))
>>>+ tf.nsect = dev->xfer_mode;
>>>+ else
>>>+ tf.nsect = 0x01;
>> This is wrong logic as I've alredy pointed out: according to the ATA-2
>>setting *any* PIO mode via 0x08..0x0c commands assumes IORDY is enabled.
>>We should only set mode 0x01 (default w/IORDY disabled) if device supports
>>IORDY and the host doesn't.
> ata_pio_need_iordy is false if
> - the controller does not support iordy
Hm, I'm sorry -- it turned out that I was looking at 2.6.21...
> or
> - mode <= PIO 2 and the device does not support iordy
> I can tighten that if to
>
> if (!ata_pio_need_iordy(dev) && ata_has_iordy(dev->id))
> tf.nsect = 0x01;
> if you prefer ?
Yeah, that'd be better. :-)
> Alan
MBR, Sergei
prev parent reply other threads:[~2007-10-15 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 18:20 [PATCH] libata-core: Drop in the final bit of IORDY handling Alan Cox
2007-10-15 19:42 ` Sergei Shtylyov
2007-10-15 20:25 ` Alan Cox
2007-10-15 20:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713CE63.2010006@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).