From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git patch] another libata fix
Date: Thu, 18 Oct 2007 16:26:26 -0400 [thread overview]
Message-ID: <4717C172.1030104@garzik.org> (raw)
In-Reply-To: <20071018202432.GA16160@havoc.gtf.org>
Jeff Garzik wrote:
> NOTE: This is appended to the previous libata fixes, in a linear
> history. If you pull this, and have not pulled yesterday's submission,
> you will get -both-. If you pulled yesterday's fixes, you will only get
> the single changeset below.
>
> Please pull from 'upstream-linus' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus
>
> to receive the following updates:
>
> drivers/ata/pdc_adma.c | 9 +-
> drivers/ata/sata_mv.c | 26 +-
> drivers/ata/sata_sil24.c | 11 +-
> drivers/scsi/ipr.c | 11 +-
> include/linux/libata.h | 12 -
> 11 files changed, 1567 insertions(+), 90 deletions(-)
> create mode 100644 drivers/ata/sata_fsl.c
>
>
> [libata] kill ata_sg_is_last()
>
> Short term, this works around a bug introduced by early sg-chaining
> work.
>
> Long term, removing this function eliminates a branch from a hot
> path loop in each scatter/gather table build. Also, as this code
> demonstrates, we don't need to _track_ the end of the s/g list, as
> long as we mark it in some way. And doing so programatically is nice.
> So its a useful cleanup, regardless of its short term effects.
>
> Based conceptually on a quick patch by Jens Axboe.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
And if it wasn't clear from the flurry of emails, this is independent
from and parallel to Jens' current work.
So, it should not conflict, and it fixes several do-not-work-at-all
drivers broken by sg-chaining.
Jeff
prev parent reply other threads:[~2007-10-18 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 20:24 [git patch] another libata fix Jeff Garzik
2007-10-18 20:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4717C172.1030104@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).