From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: FW: LIBATA issue with SATA drive Date: Fri, 19 Oct 2007 11:36:27 +0900 Message-ID: <4718182B.9040802@gmail.com> References: <4716DC7D.6050007@gmail.com> <64bb37e0710181152j7d070258w9b9eeb59cf1f0a1d@mail.gmail.com> <471804CA.9040103@gmail.com> <47180928.3020104@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wa-out-1112.google.com ([209.85.146.180]:24427 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761597AbXJSCgf (ORCPT ); Thu, 18 Oct 2007 22:36:35 -0400 Received: by wa-out-1112.google.com with SMTP id v27so421199wah for ; Thu, 18 Oct 2007 19:36:35 -0700 (PDT) In-Reply-To: <47180928.3020104@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Torsten Kaiser , "Ip, Clarence" , linux-ide@vger.kernel.org, jens.axboe@oracle.com Jeff Garzik wrote: > Tejun Heo wrote: >> Hello, >> >> Torsten Kaiser wrote: >>>> The symptom seems very similar to yours but the kernel is 2.6.22 which >>>> doesn't have the SG change which you found out to be broken. Can you >>>> update us on how the testing of patched kernel went? >>> >>> Sorry I didn't realize that you where still waiting for a 'confirm >>> good'. I intended only to mail, if I got the error again, as the debug >>> output about SGE_TRM confirmed, that this fix changes the behavior of >>> sata_sil24 and there was no really 200% sure method of detecting that >>> this bug was gone. >>> >>> Anyway, after fixing ata_sg_is_last() by adding the +1 I did not had a >>> single failure. >>> >>> I'm currently using 2.6.23-mm1 and 16 boots where all good. >>> (Apart from the unrelated failure with sata_nv and swncq...) >> >> I see, a different issue then. It's just weird to see similar issues >> popping up now after allterm the time sata_sil24 has been around. > > What kernel version are we talking about? If it includes sg-chaining > via a git tree somewhere, sata_sil24 has a bug that was just fixed (by > removing ata_sg_is_last). Yeah, that was what I thought and the reason why I cc'd Torsten but the kernel version in question here is 2.6.22. :-( -- tejun