From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 10/12] ide: add ide_tf_load() helper
Date: Sat, 20 Oct 2007 23:20:20 +0400 [thread overview]
Message-ID: <471A54F4.3010606@ru.mvista.com> (raw)
In-Reply-To: <200710082317.46641.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> Based on the earlier work by Tejun Heo.
> * Add 'tf_flags' field (for taskfile flags) to ide_task_t.
> * Add IDE_TFLAG_LBA48 taskfile flag for LBA48 taskfiles.
> * Add IDE_TFLAG_NO_SELECT_MASK taskfile flag for __ide_do_rw_disk()
> which doesn't use SELECT_MASK() (looks like a bug but it requires
> some more investigation).
> * Split off ide_tf_load() helper from do_rw_taskfile().
> * Convert __ide_do_rw_disk() to use ide_tf_load().
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Index: b/drivers/ide/ide-taskfile.c
> ===================================================================
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -62,6 +62,37 @@ static void taskfile_output_data(ide_dri
> }
> }
>
> +void ide_tf_load(ide_drive_t *drive, ide_task_t *task)
> +{
> + ide_hwif_t *hwif = drive->hwif;
> + struct ide_taskfile *tf = &task->tf;
> + u8 HIHI = (task->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
Funny name indeed. I wonder what could it mean? B-)
MBR, Sergei
prev parent reply other threads:[~2007-10-20 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 21:17 [PATCH 10/12] ide: add ide_tf_load() helper Bartlomiej Zolnierkiewicz
2007-10-20 19:20 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471A54F4.3010606@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).