From: Jeff Garzik <jeff@garzik.org>
To: Girish Shirasat <girish.shirasat@googlemail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Tejun Heo <htejun@gmail.com>,
Mark Lord <liml@rtr.ca>,
linux-ide@vger.kernel.org, Alan Cox <alan@redhat.com>
Subject: Re: AHCI with ATA/IDE Drives
Date: Mon, 22 Oct 2007 16:09:27 -0400 [thread overview]
Message-ID: <471D0377.10008@garzik.org> (raw)
In-Reply-To: <a14fb1800710221256seaae502m8092f38ba6183cc8@mail.gmail.com>
Girish Shirasat wrote:
> Hello All,
> Thanks for your replies. If we see the dump, you will observe that
> the NAND flash supports the MDMA2 but the driver does not set it but
> goes in for PIO4. On looking at the ata_port_info structure populated
> in case of 3100 SATA controller chipset namely the first entry, the
> mwdma mask is not initialized causing the driver to skip the same and
> go in for PIO modes. When I did add the MDMA mask, everything fell in
> place and I was able to access the flash devices.
> Can you please let me know if there is any specific reason as to
> why the mdma masks are not added in the ata_port_info initialisations.
We are talking about AHCI, right?
Just an oversight IIRC. ISTR the original logic was somewhat of a
guess, since ahci.c was originally written in the early SATA days -- and
also admittedly when I understood less about SATA. I was worried about
controller snooping, and also did not think it would be needed to
support MWDMA, when UDMA was supported.
Obviously those were flawed trains of thought, in hindsight.
Jeff
next prev parent reply other threads:[~2007-10-22 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 11:40 AHCI with ATA/IDE Drives Girish Shirasat
2007-10-20 13:59 ` Mark Lord
2007-10-22 9:34 ` Tejun Heo
2007-10-22 10:22 ` Alan Cox
2007-10-22 19:56 ` Girish Shirasat
2007-10-22 20:09 ` Jeff Garzik [this message]
2007-10-22 10:17 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471D0377.10008@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=girish.shirasat@googlemail.com \
--cc=htejun@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).