Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

Hi for all,
I use Kernel 2.6.22.9 with CFS-v22 patch under Debian Etch.

I cc Miquel because he is commented in man page of shutdown utilitie.

When I shutdown my laptop, I see some warnings after "Will be halt now". 
This message is something about "Spindown error" (this message is very 
fast and I can't read all warnings, and don't found it on logs).

I read in www.linux-ata.org/shutdown.html that is about shutdown utilitie.

So, my questions is:
- This is dangerous? Can damage something?
- How can I help to fix this warning?

I use ata_piix, and please keep me on cc because I don't subscribe this 
mail list.

Regards,
Renato

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Tejun Heo]

Renato S. Yamane wrote:
> Hi for all,
> I use Kernel 2.6.22.9 with CFS-v22 patch under Debian Etch.
> 
> I cc Miquel because he is commented in man page of shutdown utilitie.
> 
> When I shutdown my laptop, I see some warnings after "Will be halt now".
> This message is something about "Spindown error" (this message is very
> fast and I can't read all warnings, and don't found it on logs).
> 
> I read in www.linux-ata.org/shutdown.html that is about shutdown utilitie.
> 
> So, my questions is:
> - This is dangerous? Can damage something?

If your drive sounds funny on shutdown, it could.  Your drive is
supposed to sound the same way it sounds when you execute "hdparm -y
/dev/sdX".

> - How can I help to fix this warning?

I believe there's already update out but you can edit some configuration
file (can't remember which ATM) such that "-h" option is not passed to
halt.  Google should be able to tell you which file it is.

-- 
tejun

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Tejun Heo wrote:
> Renato S. Yamane wrote:
>> So, my questions is:
>> - This is dangerous? Can damage something?
> 
> If your drive sounds funny on shutdown, it could.  Your drive is
> supposed to sound the same way it sounds when you execute "hdparm -y
> /dev/sdX".

No strange sounds :-)

>> - How can I help to fix this warning?
> 
> I believe there's already update out but you can edit some configuration
> file (can't remember which ATM) such that "-h" option is not passed to
> halt.

Fixed. Patch is attached. Thanks!

[-- Attachment #2: halt_debian_etch.patch --]
[-- Type: text/x-diff, Size: 280 bytes --]

--- /etc/init.d/halt	2007-10-23 07:51:40.000000000 -0200
+++ /etc/init.d/halt_b	2007-10-23 07:50:52.000000000 -0200
@@ -44,7 +44,7 @@ do_stop () {
 	hddown=""
 	if grep -qs '^md.*active' /proc/mdstat
 	then
-		hddown="-h"
+		hddown=""
 	fi
 
 	# If INIT_HALT=HALT don't poweroff.

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Tejun Heo]

Renato S. Yamane wrote:
> Tejun Heo wrote:
>> Renato S. Yamane wrote:
>>> So, my questions is:
>>> - This is dangerous? Can damage something?
>>
>> If your drive sounds funny on shutdown, it could.  Your drive is
>> supposed to sound the same way it sounds when you execute "hdparm -y
>> /dev/sdX".
> 
> No strange sounds :-)
> 
>>> - How can I help to fix this warning?
>>
>> I believe there's already update out but you can edit some configuration
>> file (can't remember which ATM) such that "-h" option is not passed to
>> halt.
> 
> Fixed. Patch is attached. Thanks!

Can you write up something for other debian users so that it can be
included in the linux-ata page && cc Jeff Garzik?

-- 
tejun

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

Tejun Heo wrote:
> Renato S. Yamane wrote:
>> Fixed. Patch is attached. Thanks!
> 
> Can you write up something for other debian users so that it can be
> included in the linux-ata page && cc Jeff Garzik?

Sorry my friend, but I don't have e-mail from Jeff Garzik.

Regards,
Renato S. Yamane

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Tejun Heo]

Renato S. Yamane wrote:
> Tejun Heo wrote:
>> Renato S. Yamane wrote:
>>> Fixed. Patch is attached. Thanks!
>>
>> Can you write up something for other debian users so that it can be
>> included in the linux-ata page && cc Jeff Garzik?
> 
> Sorry my friend, but I don't have e-mail from Jeff Garzik.

cc'd.

-- 
tejun

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Tejun Heo wrote:
> Renato S. Yamane wrote:
>> Tejun Heo wrote:
>>> Renato S. Yamane wrote:
>>>> Fixed. Patch is attached. Thanks!
>>>
>>> Can you write up something for other debian users so that it can be
>>> included in the linux-ata page && cc Jeff Garzik?
>>
>> Sorry my friend, but I don't have e-mail from Jeff Garzik.
> 
> cc'd.

Jeff, patch is attached.
When I shutdown my laptop, I receive some warnings about linux-ata.
Tejun suggest remove -h option on halt script and this work fine.

Regards,
Renato

[-- Attachment #2: halt_debian_etch.patch --]
[-- Type: text/x-diff, Size: 279 bytes --]

--- /etc/init.d/halt	2007-10-23 08:33:25.000000000 -0200
+++ /etc/init.d/halt2	2007-10-23 08:31:47.000000000 -0200
@@ -44,7 +44,7 @@ do_stop () {
 	hddown=""
 	if grep -qs '^md.*active' /proc/mdstat
 	then
-		hddown="-h"
+		hddown=""
 	fi
 
 	# If INIT_HALT=HALT don't poweroff.

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Tejun Heo]

Renato S. Yamane wrote:
> Tejun Heo wrote:
>> Renato S. Yamane wrote:
>>> Tejun Heo wrote:
>>>> Renato S. Yamane wrote:
>>>>> Fixed. Patch is attached. Thanks!
>>>>
>>>> Can you write up something for other debian users so that it can be
>>>> included in the linux-ata page && cc Jeff Garzik?
>>>
>>> Sorry my friend, but I don't have e-mail from Jeff Garzik.
>>
>> cc'd.
> 
> Jeff, patch is attached.
> When I shutdown my laptop, I receive some warnings about linux-ata.
> Tejun suggest remove -h option on halt script and this work fine.

Ehh... I meant something along the line of...

"Info for Debian VERSION users : if you see this warning there are
several solutions... blah blah".

-- 
tejun

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Jim Paris]

Tejun Heo wrote:
> Ehh... I meant something along the line of...
> 
> "Info for Debian VERSION users : if you see this warning there are
> several solutions... blah blah".

For Debian, I don't think there are any complete solutions yet.
The related bug is 
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224

-jim

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

Jim Paris escreveu:
> Tejun Heo wrote:
>> Ehh... I meant something along the line of...
>>
>> "Info for Debian VERSION users : if you see this warning there are
>> several solutions... blah blah".
> 
> For Debian, I don't think there are any complete solutions yet.
> The related bug is 
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224

I think that we can fix this if someone can answer this:

$ man halt
"-h flag: This is important for IDE drives, since the kernel doesn’t 
flush the write cache itself before power-off.."

How can I know if kernel write cache itself? :-)

Regards,
Renato

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Tejun Heo]

Renato S. Yamane wrote:
> Jim Paris escreveu:
>> Tejun Heo wrote:
>>> Ehh... I meant something along the line of...
>>>
>>> "Info for Debian VERSION users : if you see this warning there are
>>> several solutions... blah blah".
>>
>> For Debian, I don't think there are any complete solutions yet.
>> The related bug is   
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224
> 
> I think that we can fix this if someone can answer this:
> 
> $ man halt
> "-h flag: This is important for IDE drives, since the kernel doesn’t 
> flush the write cache itself before power-off.."
> 
> How can I know if kernel write cache itself? :-)

Kernel has been flushing write cache for many many years now.  Man page 
needs update.  Also, flushing cache from halt is okay.  What's hurting 
is spinning down the drive from halt.

-- 
tejun

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Renato S. Yamane]

Tejun Heo wrote:
> Renato S. Yamane wrote:
>> Jim Paris wrote:
>>> For Debian, I don't think there are any complete solutions yet.
>>> The related bug is   
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224
>>
>> I think that we can fix this if someone can answer this:
>>
>> $ man halt
>> "-h flag: This is important for IDE drives, since the kernel doesn’t 
>> flush the write cache itself before power-off.."
>>
>> How can I know if kernel write cache itself? :-)
> 
> Kernel has been flushing write cache for many many years now.  Man page 
> needs update.  Also, flushing cache from halt is okay.  What's hurting 
> is spinning down the drive from halt.

So, I think that halt script need know:

- How many and who is IDE drives and SCSI/SATA drives.
- Devices with manage_start_stop as "0" or without manage_start_stop 
need "halt -h".
- Devices with manage_start_stop as "1" need only "halt".

This is correct?

Regards,
Renato

Re: Warnings on shutdown (Debian Etch and Kernel 2.6.22.9)

[Jim Paris]

Renato S. Yamane wrote:
> Tejun Heo wrote:
> >Renato S. Yamane wrote:
> >>Jim Paris wrote:
> >>>For Debian, I don't think there are any complete solutions yet.
> >>>The related bug is   
> >>>http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224
> >>
> >>I think that we can fix this if someone can answer this:
> >>
> >>$ man halt
> >>"-h flag: This is important for IDE drives, since the kernel doesn’t 
> >>flush the write cache itself before power-off.."
> >>
> >>How can I know if kernel write cache itself? :-)
> >
> >Kernel has been flushing write cache for many many years now.  Man page 
> >needs update.  Also, flushing cache from halt is okay.  What's hurting 
> >is spinning down the drive from halt.
> 
> So, I think that halt script need know:
> 
> - How many and who is IDE drives and SCSI/SATA drives.
> - Devices with manage_start_stop as "0" or without manage_start_stop 
> need "halt -h".
> - Devices with manage_start_stop as "1" need only "halt".
> 
> This is correct?

The real changes need to be made in the shutdown utility,
as described here:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224#10

-jim